Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-29 09:13:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

RAS/AMD/FMPM: Fix off by one when unwinding on error

Browse Source 
Decrement the index variable i before the first iteration when freeing
the remaining elements on error. Depending on where this fails it could
free something from one element beyond the end of the fru_records[]
array.

  [ bp: Massage commit message. ]

Fixes: 6f15e617cc ("RAS: Introduce a FRU memory poison manager")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/6fdec71a-846b-4cd0-af69-e5f6cd12f4f6@moroto.mountain
This commit is contained in:
Dan Carpenter 2024-03-06 08:30:46 +03:00 committed by Borislav Petkov (AMD)
parent 7d19eea517
commit bd17b7c34f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/ras/amd/fmpm.c
View File

@ -817,7 +817,7 @@ static int allocate_records(void)
return ret;
out_free:
for (; i >= 0; i--)
while (--i >= 0)
kfree(fru_records[i]);
kfree(fru_records);