Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-13 16:50:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mtd: rawnand: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA

Browse Source 
We already have a dependency on BCMA_NFLASH, which in turn depends on
BCMA, but since BCMA is a tristate option and BCMA_NFLASH is bool,
we can run into an invalid configuration with MTD_NAND_BCM47XXNFLASH=y
and BCMA=m:

drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.o: In function `bcm47xxnflash_ops_bcm4706_init':
ops_bcm4706.c:(.text+0x790): undefined reference to `bcma_chipco_pll_read'

Adding the dependency here forces MTD_NAND_BCM47XXNFLASH to only be
configured =m here so it can link against the BCMA driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
Arnd Bergmann 2018-07-11 10:39:44 +02:00 committed by Miquel Raynal
parent ab99e11062
commit c2204734bb
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/mtd/nand/raw/Kconfig
View File

@ -365,6 +365,7 @@ config MTD_NAND_BRCMNAND
config MTD_NAND_BCM47XXNFLASH config MTD_NAND_BCM47XXNFLASH
tristate "Support for NAND flash on BCM4706 BCMA bus" tristate "Support for NAND flash on BCM4706 BCMA bus"
depends on BCMA_NFLASH depends on BCMA_NFLASH
depends on BCMA
help help
BCMA bus can have various flash memories attached, they are BCMA bus can have various flash memories attached, they are
registered by bcma as platform devices. This enables driver for registered by bcma as platform devices. This enables driver for