Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 15:19:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

powerpc/platforms/83xx/suspend: Prevent unloading the driver

Browse Source 
Returning an error in .remove() doesn't prevent a driver from being
unloaded. On unbind this only results in an error message, but the
device is remove anyhow.

I guess the author's idea of just returning -EPERM in .remove() was to
prevent unbinding a device. To achieve that set the suppress_bind_attrs
driver property and drop the useless .remove callback.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Acked-by: Scott Wood <oss@buserror.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220707061441.193869-2-u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2022-07-07 08:14:40 +02:00 committed by Michael Ellerman
parent fde345e4d3
commit ccc1439b92
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/powerpc/platforms/83xx/suspend.c
View File

@ -421,18 +421,13 @@ out:
return ret;
}
static int pmc_remove(struct platform_device *ofdev)
{
return -EPERM;
};
static struct platform_driver pmc_driver = {
.driver = {
.name = "mpc83xx-pmc",
.of_match_table = pmc_match,
.suppress_bind_attrs = true,
},
.probe = pmc_probe,
.remove = pmc_remove
};
builtin_platform_driver(pmc_driver);