Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-13 16:50:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ASoC: Intel: Skylake: Do not disable FW notifications

Browse Source 
As per FW team recommendation we should not disable notifications.
By default, all notifications are enabled in DSP firmware. These
notifications provide a vital information whenever an error occurs.

Currently, driver disables them during boot sequences. By doing so,
Skylake may silently ignore severe stream errors.
Correct that by removing permissive code.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20190723145854.8527-6-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Amadeusz Sławiński 2019-07-23 16:58:52 +02:00 committed by Mark Brown
parent e5c29dc522
commit d4e23b7c87
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
4 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sound/soc/intel/skylake/skl-messages.c
View File

@ -58,24 +58,6 @@ void skl_dsp_set_astate_cfg(struct skl_dev *skl, u32 cnt, void *data)
skl_ipc_set_large_config(&skl->ipc, &msg, data);
}
#define NOTIFICATION_PARAM_ID 3
#define NOTIFICATION_MASK 0xf
/* disable notfication for underruns/overruns from firmware module */
void skl_dsp_enable_notification(struct skl_dev *skl, bool enable)
{
struct notification_mask mask;
struct skl_ipc_large_config_msg msg = {0};
mask.notify = NOTIFICATION_MASK;
mask.enable = enable;
msg.large_param_id = NOTIFICATION_PARAM_ID;
msg.param_data_size = sizeof(mask);
skl_ipc_set_large_config(&skl->ipc, &msg, (u32 *)&mask);
}
static int skl_dsp_setup_spib(struct device *dev, unsigned int size,
int stream_tag, int enable)
{
@ -436,8 +418,6 @@ int skl_resume_dsp(struct skl_dev *skl)
if (ret < 0)
return ret;
skl_dsp_enable_notification(skl, false);
if (skl->cfg.astate_cfg != NULL) {
skl_dsp_set_astate_cfg(skl, skl->cfg.astate_cfg->count,
skl->cfg.astate_cfg);

1
sound/soc/intel/skylake/skl-pcm.c
View File

@ -1445,7 +1445,6 @@ static int skl_platform_soc_probe(struct snd_soc_component *component)
}
skl_populate_modules(skl);
skl->update_d0i3c = skl_update_d0i3c;
skl_dsp_enable_notification(skl, false);
if (skl->cfg.astate_cfg != NULL) {
skl_dsp_set_astate_cfg(skl,

1
sound/soc/intel/skylake/skl-sst-dsp.h
View File

@ -240,7 +240,6 @@ int skl_get_pvt_instance_id_map(struct skl_dev *skl,
void skl_freeup_uuid_list(struct skl_dev *skl);
int skl_dsp_strip_extended_manifest(struct firmware *fw);
void skl_dsp_enable_notification(struct skl_dev *skl, bool enable);
void skl_dsp_set_astate_cfg(struct skl_dev *skl, u32 cnt, void *data);

5
sound/soc/intel/skylake/skl-topology.h
View File

@ -140,11 +140,6 @@ struct skl_src_module_cfg {
enum skl_s_freq src_cfg;
} __packed;
struct notification_mask {
u32 notify;
u32 enable;
} __packed;
struct skl_up_down_mixer_cfg {
struct skl_base_cfg base_cfg;
enum skl_ch_cfg out_ch_cfg;