Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2024-12-29 09:13:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

crypto: algapi - enforce that all instances have a ->free() method

Browse Source 
All instances need to have a ->free() method, but people could forget to
set it and then not notice if the instance is never unregistered.  To
help detect this bug earlier, don't allow an instance without a ->free()
method to be registered, and complain loudly if someone tries to do it.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Eric Biggers 2020-01-02 20:04:40 -08:00 committed by Herbert Xu
parent a24a1fd731
commit d4fdc2dfaa
5 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crypto/aead.c
View File

@ -288,6 +288,9 @@ int aead_register_instance(struct crypto_template *tmpl,
{
int err;
if (WARN_ON(!inst->free))
return -EINVAL;
err = aead_prepare_alg(&inst->alg);
if (err)
return err;

3
crypto/ahash.c
View File

@ -656,6 +656,9 @@ int ahash_register_instance(struct crypto_template *tmpl,
{
int err;
if (WARN_ON(!inst->free))
return -EINVAL;
err = ahash_prepare_alg(&inst->alg);
if (err)
return err;

2
crypto/akcipher.c
View File

@ -147,6 +147,8 @@ EXPORT_SYMBOL_GPL(crypto_unregister_akcipher);
int akcipher_register_instance(struct crypto_template *tmpl,
struct akcipher_instance *inst)
{
if (WARN_ON(!inst->free))
return -EINVAL;
akcipher_prepare_alg(&inst->alg);
return crypto_register_instance(tmpl, akcipher_crypto_instance(inst));
}

3
crypto/shash.c
View File

@ -577,6 +577,9 @@ int shash_register_instance(struct crypto_template *tmpl,
{
int err;
if (WARN_ON(!inst->free))
return -EINVAL;
err = shash_prepare_alg(&inst->alg);
if (err)
return err;

3
crypto/skcipher.c
View File

@ -865,6 +865,9 @@ int skcipher_register_instance(struct crypto_template *tmpl,
{
int err;
if (WARN_ON(!inst->free))
return -EINVAL;
err = skcipher_prepare_alg(&inst->alg);
if (err)
return err;