Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-19 11:43:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

iio:chemical:scd30: Use IRQF_NO_AUTOEN to avoid irq request then disable

Browse Source 
This new flag cleanly avoids the need for a dance where we request the
interrupt only to immediately disabling it by ensuring it is not
auto-enabled in the first place.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>
Reviewed-by: Barry Song <song.bao.hua@hisilicon.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210402184544.488862-6-jic23@kernel.org
This commit is contained in:
Jonathan Cameron 2021-04-02 19:45:42 +01:00
parent ff2293ea9c
commit dbb8f20d83
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/iio/chemical/scd30_core.c
View File

@ -655,19 +655,19 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
indio_dev->trig = iio_trigger_get(trig);
/*
* Interrupt is enabled just before taking a fresh measurement
* and disabled afterwards. This means we need to ensure it is not
* enabled here to keep calls to enable/disable balanced.
*/
ret = devm_request_threaded_irq(dev, state->irq, scd30_irq_handler,
scd30_irq_thread_handler, IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
scd30_irq_thread_handler,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT |
IRQF_NO_AUTOEN,
indio_dev->name, indio_dev);
if (ret)
dev_err(dev, "failed to request irq\n");
/*
* Interrupt is enabled just before taking a fresh measurement
* and disabled afterwards. This means we need to disable it here
* to keep calls to enable/disable balanced.
*/
disable_irq(state->irq);
return ret;
}