mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-06 05:13:18 +00:00
xfs: use memcpy, not strncpy, to format the attr prefix during listxattr
When -Wstringop-truncation is enabled, the compiler complains about truncation of the null byte at the end of the xattr name prefix. This is intentional, since we're concatenating the two strings together and do _not_ want a null byte in the middle of the name. We've already ensured that the name buffer is long enough to handle prefix and name, and the prefix_len is supposed to be the length of the prefix string without the null byte, so use memcpy here instead. Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> Reviewed-by: Dave Chinner <dchinner@redhat.com>
This commit is contained in:
parent
032e160305
commit
fd5beaff25
@ -210,7 +210,7 @@ __xfs_xattr_put_listent(
|
||||
return;
|
||||
}
|
||||
offset = context->buffer + context->count;
|
||||
strncpy(offset, prefix, prefix_len);
|
||||
memcpy(offset, prefix, prefix_len);
|
||||
offset += prefix_len;
|
||||
strncpy(offset, (char *)name, namelen); /* real name */
|
||||
offset += namelen;
|
||||
|
Loading…
Reference in New Issue
Block a user