mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2024-12-28 16:53:49 +00:00
157ce8f381
Some devices are designed and manufactured with some components having multiple drop-in replacement options. These components are often connected to the mainboard via ribbon cables, having the same signals and pin assignments across all options. These may include the display panel and touchscreen on laptops and tablets, and the trackpad on laptops. Sometimes which component option is used in a particular device can be detected by some firmware provided identifier, other times that information is not available, and the kernel has to try to probe each device. This change attempts to make the "probe each device" case cleaner. The current approach is to have all options added and enabled in the device tree. The kernel would then bind each device and run each driver's probe function. This works, but has been broken before due to the introduction of asynchronous probing, causing multiple instances requesting "shared" resources, such as pinmuxes, GPIO pins, interrupt lines, at the same time, with only one instance succeeding. Work arounds for these include moving the pinmux to the parent I2C controller, using GPIO hogs or pinmux settings to keep the GPIO pins in some fixed configuration, and requesting the interrupt line very late. Such configurations can be seen on the MT8183 Krane Chromebook tablets, and the Qualcomm sc8280xp-based Lenovo Thinkpad 13S. Instead of this delicate dance between drivers and device tree quirks, this change introduces a simple I2C component probe function. For a given class of devices on the same I2C bus, it will go through all of them, doing a simple I2C read transfer and see which one of them responds. It will then enable the device that responds. This requires some minor modifications in the existing device tree. The status for all the device nodes for the component options must be set to "fail-needs-probe". This makes it clear that some mechanism is needed to enable one of them, and also prevents the prober and device drivers running at the same time. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
24 lines
764 B
Makefile
24 lines
764 B
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Makefile for the i2c core.
|
|
#
|
|
|
|
obj-$(CONFIG_I2C_BOARDINFO) += i2c-boardinfo.o
|
|
obj-$(CONFIG_I2C) += i2c-core.o
|
|
i2c-core-y := i2c-core-base.o i2c-core-smbus.o
|
|
i2c-core-$(CONFIG_ACPI) += i2c-core-acpi.o
|
|
i2c-core-$(CONFIG_I2C_SLAVE) += i2c-core-slave.o
|
|
i2c-core-$(CONFIG_OF) += i2c-core-of.o
|
|
i2c-core-$(CONFIG_OF_DYNAMIC) += i2c-core-of-prober.o
|
|
|
|
obj-$(CONFIG_I2C_SMBUS) += i2c-smbus.o
|
|
obj-$(CONFIG_I2C_CHARDEV) += i2c-dev.o
|
|
obj-$(CONFIG_I2C_MUX) += i2c-mux.o
|
|
obj-$(CONFIG_I2C_ATR) += i2c-atr.o
|
|
obj-y += algos/ busses/ muxes/
|
|
obj-$(CONFIG_I2C_STUB) += i2c-stub.o
|
|
obj-$(CONFIG_I2C_SLAVE_EEPROM) += i2c-slave-eeprom.o
|
|
obj-$(CONFIG_I2C_SLAVE_TESTUNIT) += i2c-slave-testunit.o
|
|
|
|
ccflags-$(CONFIG_I2C_DEBUG_CORE) := -DDEBUG
|