mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-15 01:24:33 +00:00
9b5c87d479
Since 7d6be67cfdd4 ("mm: mmap_lock: replace get_memcg_path_buf() with
on-stack buffer") we use trace_mmap_lock_reg()/unreg() only to maintain an
atomic reg_refcount which is checked to avoid performing
get_mm_memcg_path() in case none of the tracepoints using it is enabled.
This can be achieved directly by putting all the work needed for the
tracepoint behind the trace_mmap_lock_##type##_enabled(), as suggested by
Documentation/trace/tracepoints.rst and with the following advantages:
- uses the tracepoint's static key instead of evaluating a branch
- the check tracepoint specific, not shared by all of them
- we can get rid of trace_mmap_lock_reg()/unreg() completely
Thus use the trace_..._enabled() check and remove unnecessary code.
Link: https://lkml.kernel.org/r/20241105113456.95066-2-vbabka@suse.cz
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
82 lines
1.8 KiB
C
82 lines
1.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM mmap_lock
|
|
|
|
#if !defined(_TRACE_MMAP_LOCK_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_MMAP_LOCK_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
#include <linux/types.h>
|
|
|
|
struct mm_struct;
|
|
|
|
DECLARE_EVENT_CLASS(mmap_lock,
|
|
|
|
TP_PROTO(struct mm_struct *mm, const char *memcg_path, bool write),
|
|
|
|
TP_ARGS(mm, memcg_path, write),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct mm_struct *, mm)
|
|
__string(memcg_path, memcg_path)
|
|
__field(bool, write)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->mm = mm;
|
|
__assign_str(memcg_path);
|
|
__entry->write = write;
|
|
),
|
|
|
|
TP_printk(
|
|
"mm=%p memcg_path=%s write=%s",
|
|
__entry->mm,
|
|
__get_str(memcg_path),
|
|
__entry->write ? "true" : "false"
|
|
)
|
|
);
|
|
|
|
#define DEFINE_MMAP_LOCK_EVENT(name) \
|
|
DEFINE_EVENT(mmap_lock, name, \
|
|
TP_PROTO(struct mm_struct *mm, const char *memcg_path, \
|
|
bool write), \
|
|
TP_ARGS(mm, memcg_path, write))
|
|
|
|
DEFINE_MMAP_LOCK_EVENT(mmap_lock_start_locking);
|
|
DEFINE_MMAP_LOCK_EVENT(mmap_lock_released);
|
|
|
|
TRACE_EVENT(mmap_lock_acquire_returned,
|
|
|
|
TP_PROTO(struct mm_struct *mm, const char *memcg_path, bool write,
|
|
bool success),
|
|
|
|
TP_ARGS(mm, memcg_path, write, success),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct mm_struct *, mm)
|
|
__string(memcg_path, memcg_path)
|
|
__field(bool, write)
|
|
__field(bool, success)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->mm = mm;
|
|
__assign_str(memcg_path);
|
|
__entry->write = write;
|
|
__entry->success = success;
|
|
),
|
|
|
|
TP_printk(
|
|
"mm=%p memcg_path=%s write=%s success=%s",
|
|
__entry->mm,
|
|
__get_str(memcg_path),
|
|
__entry->write ? "true" : "false",
|
|
__entry->success ? "true" : "false"
|
|
)
|
|
);
|
|
|
|
#endif /* _TRACE_MMAP_LOCK_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|