mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-15 01:24:33 +00:00
33580d667b
As one can see in include/trace/stages/stage4_event_fields.h, the
implementation of __field() uses the is_signed_type() macro. As one can
see in commit dcf8e5633e2e ("tracing: Define the is_signed_type() macro
once"), there has been an attempt to not make is_signed_type() trigger
sparse warnings for bitwise types.
Despite that change, sparse complains when passing a bitwise type to
is_signed_type(). The reason is that in its definition below, an
inequality comparison will be made against bitwise types, which are random
collections of bits (the casts to bitwise types themselves are
semantically valid and not problematic):
#define is_signed_type(type) (((type)(-1)) < (__force type)1)
So, as a workaround, follow the example of <trace/events/initcall.h> and
suppress the following sparse warnings by changing __field() into
__field_struct() that doesn't use is_signed_type():
fs/nilfs2/segment.c: note: in included file (through
include/trace/trace_events.h, include/trace/define_trace.h,
include/trace/events/nilfs2.h):
./include/trace/events/nilfs2.h:191:1: warning: cast to restricted
blk_opf_t
./include/trace/events/nilfs2.h:191:1: warning: restricted blk_opf_t
degrades to integer
./include/trace/events/nilfs2.h:191:1: warning: restricted blk_opf_t
degrades to integer
[konishi.ryusuke: describe the reason for the warnings per Linus's explanation]
Link: https://lkml.kernel.org/r/20240507222041.4876-1-konishi.ryusuke@gmail.com
Link: https://lkml.kernel.org/r/20240507142454.3344-1-konishi.ryusuke@gmail.com
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401092241.I4mm9OWl-lkp@intel.com/
Reported-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Closes: https://lore.kernel.org/all/20240430080019.4242-2-konishi.ryusuke@gmail.com/
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
230 lines
5.3 KiB
C
230 lines
5.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM nilfs2
|
|
|
|
#if !defined(_TRACE_NILFS2_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_NILFS2_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
|
|
struct nilfs_sc_info;
|
|
|
|
#define show_collection_stage(type) \
|
|
__print_symbolic(type, \
|
|
{ NILFS_ST_INIT, "ST_INIT" }, \
|
|
{ NILFS_ST_GC, "ST_GC" }, \
|
|
{ NILFS_ST_FILE, "ST_FILE" }, \
|
|
{ NILFS_ST_IFILE, "ST_IFILE" }, \
|
|
{ NILFS_ST_CPFILE, "ST_CPFILE" }, \
|
|
{ NILFS_ST_SUFILE, "ST_SUFILE" }, \
|
|
{ NILFS_ST_DAT, "ST_DAT" }, \
|
|
{ NILFS_ST_SR, "ST_SR" }, \
|
|
{ NILFS_ST_DSYNC, "ST_DSYNC" }, \
|
|
{ NILFS_ST_DONE, "ST_DONE"})
|
|
|
|
TRACE_EVENT(nilfs2_collection_stage_transition,
|
|
|
|
TP_PROTO(struct nilfs_sc_info *sci),
|
|
|
|
TP_ARGS(sci),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(void *, sci)
|
|
__field(int, stage)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->sci = sci;
|
|
__entry->stage = sci->sc_stage.scnt;
|
|
),
|
|
|
|
TP_printk("sci = %p stage = %s",
|
|
__entry->sci,
|
|
show_collection_stage(__entry->stage))
|
|
);
|
|
|
|
#ifndef TRACE_HEADER_MULTI_READ
|
|
enum nilfs2_transaction_transition_state {
|
|
TRACE_NILFS2_TRANSACTION_BEGIN,
|
|
TRACE_NILFS2_TRANSACTION_COMMIT,
|
|
TRACE_NILFS2_TRANSACTION_ABORT,
|
|
TRACE_NILFS2_TRANSACTION_TRYLOCK,
|
|
TRACE_NILFS2_TRANSACTION_LOCK,
|
|
TRACE_NILFS2_TRANSACTION_UNLOCK,
|
|
};
|
|
#endif
|
|
|
|
#define show_transaction_state(type) \
|
|
__print_symbolic(type, \
|
|
{ TRACE_NILFS2_TRANSACTION_BEGIN, "BEGIN" }, \
|
|
{ TRACE_NILFS2_TRANSACTION_COMMIT, "COMMIT" }, \
|
|
{ TRACE_NILFS2_TRANSACTION_ABORT, "ABORT" }, \
|
|
{ TRACE_NILFS2_TRANSACTION_TRYLOCK, "TRYLOCK" }, \
|
|
{ TRACE_NILFS2_TRANSACTION_LOCK, "LOCK" }, \
|
|
{ TRACE_NILFS2_TRANSACTION_UNLOCK, "UNLOCK" })
|
|
|
|
TRACE_EVENT(nilfs2_transaction_transition,
|
|
TP_PROTO(struct super_block *sb,
|
|
struct nilfs_transaction_info *ti,
|
|
int count,
|
|
unsigned int flags,
|
|
enum nilfs2_transaction_transition_state state),
|
|
|
|
TP_ARGS(sb, ti, count, flags, state),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(void *, sb)
|
|
__field(void *, ti)
|
|
__field(int, count)
|
|
__field(unsigned int, flags)
|
|
__field(int, state)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->sb = sb;
|
|
__entry->ti = ti;
|
|
__entry->count = count;
|
|
__entry->flags = flags;
|
|
__entry->state = state;
|
|
),
|
|
|
|
TP_printk("sb = %p ti = %p count = %d flags = %x state = %s",
|
|
__entry->sb,
|
|
__entry->ti,
|
|
__entry->count,
|
|
__entry->flags,
|
|
show_transaction_state(__entry->state))
|
|
);
|
|
|
|
TRACE_EVENT(nilfs2_segment_usage_check,
|
|
TP_PROTO(struct inode *sufile,
|
|
__u64 segnum,
|
|
unsigned long cnt),
|
|
|
|
TP_ARGS(sufile, segnum, cnt),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct inode *, sufile)
|
|
__field(__u64, segnum)
|
|
__field(unsigned long, cnt)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->sufile = sufile;
|
|
__entry->segnum = segnum;
|
|
__entry->cnt = cnt;
|
|
),
|
|
|
|
TP_printk("sufile = %p segnum = %llu cnt = %lu",
|
|
__entry->sufile,
|
|
__entry->segnum,
|
|
__entry->cnt)
|
|
);
|
|
|
|
TRACE_EVENT(nilfs2_segment_usage_allocated,
|
|
TP_PROTO(struct inode *sufile,
|
|
__u64 segnum),
|
|
|
|
TP_ARGS(sufile, segnum),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct inode *, sufile)
|
|
__field(__u64, segnum)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->sufile = sufile;
|
|
__entry->segnum = segnum;
|
|
),
|
|
|
|
TP_printk("sufile = %p segnum = %llu",
|
|
__entry->sufile,
|
|
__entry->segnum)
|
|
);
|
|
|
|
TRACE_EVENT(nilfs2_segment_usage_freed,
|
|
TP_PROTO(struct inode *sufile,
|
|
__u64 segnum),
|
|
|
|
TP_ARGS(sufile, segnum),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct inode *, sufile)
|
|
__field(__u64, segnum)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->sufile = sufile;
|
|
__entry->segnum = segnum;
|
|
),
|
|
|
|
TP_printk("sufile = %p segnum = %llu",
|
|
__entry->sufile,
|
|
__entry->segnum)
|
|
);
|
|
|
|
TRACE_EVENT(nilfs2_mdt_insert_new_block,
|
|
TP_PROTO(struct inode *inode,
|
|
unsigned long ino,
|
|
unsigned long block),
|
|
|
|
TP_ARGS(inode, ino, block),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct inode *, inode)
|
|
__field(unsigned long, ino)
|
|
__field(unsigned long, block)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->inode = inode;
|
|
__entry->ino = ino;
|
|
__entry->block = block;
|
|
),
|
|
|
|
TP_printk("inode = %p ino = %lu block = %lu",
|
|
__entry->inode,
|
|
__entry->ino,
|
|
__entry->block)
|
|
);
|
|
|
|
TRACE_EVENT(nilfs2_mdt_submit_block,
|
|
TP_PROTO(struct inode *inode,
|
|
unsigned long ino,
|
|
unsigned long blkoff,
|
|
enum req_op mode),
|
|
|
|
TP_ARGS(inode, ino, blkoff, mode),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(struct inode *, inode)
|
|
__field(unsigned long, ino)
|
|
__field(unsigned long, blkoff)
|
|
/*
|
|
* Use field_struct() to avoid is_signed_type() on the
|
|
* bitwise type enum req_op.
|
|
*/
|
|
__field_struct(enum req_op, mode)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->inode = inode;
|
|
__entry->ino = ino;
|
|
__entry->blkoff = blkoff;
|
|
__entry->mode = mode;
|
|
),
|
|
|
|
TP_printk("inode = %p ino = %lu blkoff = %lu mode = %x",
|
|
__entry->inode,
|
|
__entry->ino,
|
|
__entry->blkoff,
|
|
__entry->mode)
|
|
);
|
|
|
|
#endif /* _TRACE_NILFS2_H */
|
|
|
|
/* This part must be outside protection */
|
|
#undef TRACE_INCLUDE_FILE
|
|
#define TRACE_INCLUDE_FILE nilfs2
|
|
#include <trace/define_trace.h>
|