mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-15 01:24:33 +00:00
2c92ca849f
With the rework of how the __string() handles dynamic strings where it
saves off the source string in field in the helper structure[1], the
assignment of that value to the trace event field is stored in the helper
value and does not need to be passed in again.
This means that with:
__string(field, mystring)
Which use to be assigned with __assign_str(field, mystring), no longer
needs the second parameter and it is unused. With this, __assign_str()
will now only get a single parameter.
There's over 700 users of __assign_str() and because coccinelle does not
handle the TRACE_EVENT() macro I ended up using the following sed script:
git grep -l __assign_str | while read a ; do
sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
mv /tmp/test-file $a;
done
I then searched for __assign_str() that did not end with ';' as those
were multi line assignments that the sed script above would fail to catch.
Note, the same updates will need to be done for:
__assign_str_len()
__assign_rel_str()
__assign_rel_str_len()
I tested this with both an allmodconfig and an allyesconfig (build only for both).
[1] https://lore.kernel.org/linux-trace-kernel/20240222211442.634192653@goodmis.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240516133454.681ba6a0@rorschach.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Christian König <christian.koenig@amd.com> for the amdgpu parts.
Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> #for
Acked-by: Rafael J. Wysocki <rafael@kernel.org> # for thermal
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Darrick J. Wong <djwong@kernel.org> # xfs
Tested-by: Guenter Roeck <linux@roeck-us.net>
62 lines
1.5 KiB
C
62 lines
1.5 KiB
C
#if !defined(_TRACE_TEGRA_APB_DMA_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_TEGRA_APB_DMA_H
|
|
|
|
#include <linux/tracepoint.h>
|
|
#include <linux/dmaengine.h>
|
|
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM tegra_apb_dma
|
|
|
|
TRACE_EVENT(tegra_dma_tx_status,
|
|
TP_PROTO(struct dma_chan *dc, dma_cookie_t cookie, struct dma_tx_state *state),
|
|
TP_ARGS(dc, cookie, state),
|
|
TP_STRUCT__entry(
|
|
__string(chan, dev_name(&dc->dev->device))
|
|
__field(dma_cookie_t, cookie)
|
|
__field(__u32, residue)
|
|
),
|
|
TP_fast_assign(
|
|
__assign_str(chan);
|
|
__entry->cookie = cookie;
|
|
__entry->residue = state ? state->residue : (u32)-1;
|
|
),
|
|
TP_printk("channel %s: dma cookie %d, residue %u",
|
|
__get_str(chan), __entry->cookie, __entry->residue)
|
|
);
|
|
|
|
TRACE_EVENT(tegra_dma_complete_cb,
|
|
TP_PROTO(struct dma_chan *dc, int count, void *ptr),
|
|
TP_ARGS(dc, count, ptr),
|
|
TP_STRUCT__entry(
|
|
__string(chan, dev_name(&dc->dev->device))
|
|
__field(int, count)
|
|
__field(void *, ptr)
|
|
),
|
|
TP_fast_assign(
|
|
__assign_str(chan);
|
|
__entry->count = count;
|
|
__entry->ptr = ptr;
|
|
),
|
|
TP_printk("channel %s: done %d, ptr %p",
|
|
__get_str(chan), __entry->count, __entry->ptr)
|
|
);
|
|
|
|
TRACE_EVENT(tegra_dma_isr,
|
|
TP_PROTO(struct dma_chan *dc, int irq),
|
|
TP_ARGS(dc, irq),
|
|
TP_STRUCT__entry(
|
|
__string(chan, dev_name(&dc->dev->device))
|
|
__field(int, irq)
|
|
),
|
|
TP_fast_assign(
|
|
__assign_str(chan);
|
|
__entry->irq = irq;
|
|
),
|
|
TP_printk("%s: irq %d\n", __get_str(chan), __entry->irq)
|
|
);
|
|
|
|
#endif /* _TRACE_TEGRA_APB_DMA_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|