linux/net/mctp
Jeremy Kerr ce1219c3f7 net: mctp: handle skb cleanup on sock_queue failures
Currently, we don't use the return value from sock_queue_rcv_skb, which
means we may leak skbs if a message is not successfully queued to a
socket.

Instead, ensure that we're freeing the skb where the sock hasn't
otherwise taken ownership of the skb by adding checks on the
sock_queue_rcv_skb() to invoke a kfree on failure.

In doing so, rather than using the 'rc' value to trigger the
kfree_skb(), use the skb pointer itself, which is more explicit.

Also, add a kunit test for the sock delivery failure cases.

Fixes: 4a992bbd36 ("mctp: Implement message fragmentation & reassembly")
Cc: stable@vger.kernel.org
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Link: https://patch.msgid.link/20241218-mctp-next-v2-1-1c1729645eaa@codeconstruct.com.au
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2024-12-19 11:52:49 +01:00
..
test net: mctp: handle skb cleanup on sock_queue failures 2024-12-19 11:52:49 +01:00
af_mctp.c mctp: Handle error of rtnl_register_module(). 2024-10-10 15:39:35 +02:00
device.c net: mctp: Expose transport binding identifier via IFLA attribute 2024-11-09 09:04:54 -08:00
Kconfig net: mctp: tests: Test that outgoing skbs have flow data populated 2024-02-22 13:32:55 +01:00
Makefile mctp: Add test utils 2021-10-03 14:35:41 +01:00
neigh.c mctp: Handle error of rtnl_register_module(). 2024-10-10 15:39:35 +02:00
route.c net: mctp: handle skb cleanup on sock_queue failures 2024-12-19 11:52:49 +01:00