Mike Snitzer 4328daa2e7 dm: fix dm_rq_target_io leak on faults with .request_fn DM w/ blk-mq paths ...

Using request-based DM mpath configured with the following stacking
(.request_fn DM mpath ontop of scsi-mq paths):

echo Y > /sys/module/scsi_mod/parameters/use_blk_mq
echo N > /sys/module/dm_mod/parameters/use_blk_mq

'struct dm_rq_target_io' would leak if a request is requeued before a
blk-mq clone is allocated (or fails to allocate).  free_rq_tio()
wasn't being called.

kmemleak reported:

unreferenced object 0xffff8800b90b98c0 (size 112):
  comm "kworker/7:1H", pid 5692, jiffies 4295056109 (age 78.589s)
  hex dump (first 32 bytes):
    00 d0 5c 2c 03 88 ff ff 40 00 bf 01 00 c9 ff ff  ..\,....@.......
    e0 d9 b1 34 00 88 ff ff 00 00 00 00 00 00 00 00  ...4............
  backtrace:
    [<ffffffff81672b6e>] kmemleak_alloc+0x4e/0xb0
    [<ffffffff811dbb63>] kmem_cache_alloc+0xc3/0x1e0
    [<ffffffff8117eae5>] mempool_alloc_slab+0x15/0x20
    [<ffffffff8117ec1e>] mempool_alloc+0x6e/0x170
    [<ffffffffa00029ac>] dm_old_prep_fn+0x3c/0x180 [dm_mod]
    [<ffffffff812fbd78>] blk_peek_request+0x168/0x290
    [<ffffffffa0003e62>] dm_request_fn+0xb2/0x1b0 [dm_mod]
    [<ffffffff812f66e3>] __blk_run_queue+0x33/0x40
    [<ffffffff812f9585>] blk_delay_work+0x25/0x40
    [<ffffffff81096fff>] process_one_work+0x14f/0x3d0
    [<ffffffff81097715>] worker_thread+0x125/0x4b0
    [<ffffffff8109ce88>] kthread+0xd8/0xf0
    [<ffffffff8167cb8f>] ret_from_fork+0x3f/0x70
    [<ffffffffffffffff>] 0xffffffffffffffff

crash> struct -o dm_rq_target_io
struct dm_rq_target_io {
    ...
}
SIZE: 112

Fixes: e5863d9ad7 ("dm: allocate requests in target when stacking on blk-mq devices")
Cc: stable@vger.kernel.org # 4.0+
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

2016-02-21 20:27:50 -05:00

..

bcache

Merge branch 'for-4.5/drivers' of git://git.kernel.dk/linux-block

2016-01-21 18:19:38 -08:00

persistent-data

dm space map metadata: remove unused variable in brb_pop()

2015-12-14 09:26:01 -05:00

bitmap.c

md-cluster: delete useless code

2016-01-24 18:13:37 -08:00

bitmap.h

md-cluster: Use a small window for resync

2015-10-12 01:32:05 -05:00

dm-bio-prison.c

block: add a bi_error field to struct bio

2015-07-29 08:55:15 -06:00

dm-bio-prison.h

dm bio prison: add dm_cell_promote_or_release()

2015-05-29 14:19:06 -04:00

dm-bio-record.h

dm: Refactor for new bio cloning/splitting

2013-11-23 22:33:55 -08:00

dm-bufio.c

Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2016-01-12 17:11:47 -08:00

dm-bufio.h

dm snapshot: use dm-bufio prefetch

2014-01-14 23:23:03 -05:00

dm-builtin.c

dm sysfs: fix a module unload race

2014-01-14 23:23:04 -05:00

dm-cache-block-types.h

dm cache: revert "remove remainder of distinct discard block size"

2014-11-10 15:25:30 -05:00

dm-cache-metadata.c

- Revert a dm-multipath change that caused a regression for unprivledged

2015-11-04 21:19:53 -08:00

dm-cache-metadata.h

dm cache: add fail io mode and needs_check flag

2015-06-11 17:13:00 -04:00

dm-cache-policy-cleaner.c

- Revert a dm-multipath change that caused a regression for unprivledged

2015-11-04 21:19:53 -08:00

dm-cache-policy-internal.h

dm cache: age and write back cache entries even without active IO

2015-06-11 17:13:01 -04:00

dm-cache-policy-mq.c

dm: convert ffs to __ffs

2015-10-31 19:06:01 -04:00

dm-cache-policy-smq.c

dm: convert ffs to __ffs

2015-10-31 19:06:01 -04:00

dm-cache-policy.c

dm cache: add policy name to status output

2014-01-16 13:44:11 -05:00

dm-cache-policy.h

dm cache: age and write back cache entries even without active IO

2015-06-11 17:13:01 -04:00

dm-cache-target.c

dm: don't save and restore bi_private

2015-12-10 10:38:56 -05:00

dm-crypt.c

dm crypt: fix a possible hang due to race condition on exit

2015-11-19 13:38:30 -05:00

dm-delay.c

dm delay: document that offsets are specified in sectors

2015-10-31 19:06:05 -04:00

dm-era-target.c

dm persistent data: eliminate unnecessary return values

2015-10-31 19:06:02 -04:00

dm-exception-store.c

- Revert a dm-multipath change that caused a regression for unprivledged

2015-11-04 21:19:53 -08:00

dm-exception-store.h

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-flakey.c

dm: refactor ioctl handling

2015-10-31 19:05:59 -04:00

dm-io.c

md: more open-coded offset_in_page()

2016-01-04 10:29:12 -05:00

dm-ioctl.c

char: make misc_deregister a void function

2015-08-05 10:35:49 -07:00

dm-kcopyd.c

mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd

2015-11-06 17:50:42 -08:00

dm-linear.c

dm linear: remove redundant target name from error messages

2015-10-31 19:06:03 -04:00

dm-log-userspace-base.c

dm: drop NULL test before kmem_cache_destroy() and mempool_destroy()

2015-10-31 19:06:00 -04:00

dm-log-userspace-transfer.c

dm log userspace transfer: match wait_for_completion_timeout return type

2015-04-15 12:10:20 -04:00

dm-log-userspace-transfer.h

dm log: userspace add luid to distinguish between concurrent log instances

2009-09-04 20:40:34 +01:00

dm-log-writes.c

dm: refactor ioctl handling

2015-10-31 19:05:59 -04:00

dm-log.c

dm: use memweight()

2012-07-30 17:25:16 -07:00

dm-mpath.c

dm mpath: fix infinite recursion in ioctl when no paths and !queue_if_no_path

2015-11-17 14:19:00 -05:00

dm-mpath.h

dm mpath: remove is_active from struct dm_path

2008-10-10 13:36:58 +01:00

dm-path-selector.c

md: Add module.h to all files using it implicitly

2011-10-31 19:31:18 -04:00

dm-path-selector.h

dm mpath: add start_io and nr_bytes to path selectors

2009-06-22 10:12:27 +01:00

dm-queue-length.c

dm: reject trailing characters in sccanf input

2012-03-28 18:41:26 +01:00

dm-raid1.c

Merge tag 'dm-4.3-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2015-09-02 16:35:26 -07:00

dm-raid.c

dm raid: fix round up of default region size

2015-10-02 12:02:31 -04:00

dm-region-hash.c

dm: convert ffs to __ffs

2015-10-31 19:06:01 -04:00

dm-round-robin.c

dm: reject trailing characters in sccanf input

2012-03-28 18:41:26 +01:00

dm-service-time.c

dm: reject trailing characters in sccanf input

2012-03-28 18:41:26 +01:00

dm-snap-persistent.c

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-snap-transient.c

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-snap.c

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-stats.c

dm stats: report precise_timestamps and histogram in @stats_list output

2015-08-18 17:20:03 -04:00

dm-stats.h

dm stats: support precise timestamps

2015-06-17 12:40:40 -04:00

dm-stripe.c

Merge tag 'dm-4.3-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2015-09-02 16:35:26 -07:00

dm-switch.c

dm switch: simplify conditional in alloc_region_table()

2015-10-31 19:06:06 -04:00

dm-sysfs.c

dm: add 'use_blk_mq' module param and expose in per-device ro sysfs attr

2015-04-15 12:10:17 -04:00

dm-table.c

block: Inline blk_integrity in struct gendisk

2015-10-21 14:42:42 -06:00

dm-target.c

dm: allocate requests in target when stacking on blk-mq devices

2015-02-09 13:06:47 -05:00

dm-thin-metadata.c

dm thin metadata: make dm_thin_find_mapped_range() atomic

2015-12-10 10:38:55 -05:00

dm-thin-metadata.h

dm thin metadata: add dm_thin_remove_range()

2015-06-11 17:13:04 -04:00

dm-thin.c

dm thin: bump thin and thin-pool target versions

2016-01-06 20:59:40 -05:00

dm-uevent.c

md: Add in export.h for files using EXPORT_SYMBOL

2011-10-31 19:31:19 -04:00

dm-uevent.h

dm: uevent generate events

2007-10-20 02:01:26 +01:00

dm-verity-fec.c

dm verity: add ignore_zero_blocks feature

2015-12-10 10:39:03 -05:00

dm-verity-fec.h

dm verity: add support for forward error correction

2015-12-10 10:39:03 -05:00

dm-verity-target.c

dm verity: add ignore_zero_blocks feature

2015-12-10 10:39:03 -05:00

dm-verity.h

dm verity: add ignore_zero_blocks feature

2015-12-10 10:39:03 -05:00

dm-zero.c

block: add a bi_error field to struct bio

2015-07-29 08:55:15 -06:00

dm.c

dm: fix dm_rq_target_io leak on faults with .request_fn DM w/ blk-mq paths

2016-02-21 20:27:50 -05:00

dm.h

block: kill merge_bvec_fn() completely

2015-08-13 12:31:57 -06:00

faulty.c

MD: rename some functions

2016-01-20 13:52:20 -08:00

Kconfig

dm verity: add support for forward error correction

2015-12-10 10:39:03 -05:00

linear.c

block: kill merge_bvec_fn() completely

2015-08-13 12:31:57 -06:00

linear.h

md/linear: typedef removal: linear_conf_t -> struct linear_conf

2011-10-11 16:48:54 +11:00

Makefile

dm verity: add support for forward error correction

2015-12-10 10:39:03 -05:00

md-cluster.c

md-cluster: fix missing memory free

2016-01-24 18:13:18 -08:00

md-cluster.h

md-cluster: append some actions when change bitmap from clustered to none

2016-01-06 11:38:57 +11:00

md.c

md updates for 4.5

2016-01-15 12:28:00 -08:00

md.h

md updates for 4.5

2016-01-15 12:28:00 -08:00

multipath.c

md/raid: only permit hot-add of compatible integrity profiles

2016-01-14 11:49:57 +11:00

multipath.h

md/multipath: typedef removal: multipath_conf_t -> struct mpconf

2011-10-11 16:48:57 +11:00

raid0.c

treewide: Fix typos in printk

2015-12-08 14:59:19 +01:00

raid0.h

block: kill merge_bvec_fn() completely

2015-08-13 12:31:57 -06:00

raid1.c

MD: rename some functions

2016-01-20 13:52:20 -08:00

raid1.h

md-cluster: Use a small window for resync

2015-10-12 01:32:05 -05:00

raid5-cache.c

raid5-cache: handle journal hotadd in quiesce

2016-01-14 11:49:43 +11:00

raid5.c

MD: rename some functions

2016-01-20 13:52:20 -08:00

raid5.h

raid5-cache: IO error handling

2015-11-01 13:48:29 +11:00

raid10.c

MD: rename some functions

2016-01-20 13:52:20 -08:00

raid10.h

md/raid10: ensure device failure recorded before write request returns.

2015-08-31 19:43:45 +02:00