Christoph Hellwig
1b9474635e
cifs: truncate fallout
...
Remove the calls to inode_newsize_ok given that we already did it as
part of inode_change_ok in the beginning of cifs_setattr_(no)unix.
No need to call ->truncate if cifs doesn't have one, so remove the
explicit call in cifs_vmtruncate, and replace the calls to vmtruncate
with truncate_setsize which is vmtruncate minus inode_newsize_ok
and the call to ->truncate.
Rename cifs_vmtruncate to cifs_setsize to match the new calling conventions.
Question 1: why does cifs do the pagecache munging and i_size update twice
for each setattr call, once opencoded in cifs_vmtruncate, and once
using the VFS helpers?
Question 2: what is supposed to be protected by i_lock in cifs_vmtruncate?
Do we need it around the call to inode_change_ok?
[AV: fixed build breakage]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2010-08-09 16:48:48 -04:00
..
2010-08-09 16:48:37 -04:00
2010-08-09 16:47:39 -04:00
2010-08-09 16:48:06 -04:00
2010-08-09 16:48:37 -04:00
2010-05-27 09:12:56 -07:00
2010-05-27 09:12:41 -07:00
2010-03-30 22:02:32 +09:00
2010-08-09 16:48:04 -04:00
2010-08-09 16:48:35 -04:00
2010-08-09 16:48:42 -04:00
2010-07-27 13:11:17 -07:00
2010-08-09 16:48:48 -04:00
2010-08-09 16:48:37 -04:00
2010-06-04 17:16:29 -04:00
2010-08-09 16:47:51 -04:00
2010-05-19 22:41:57 -04:00
2010-05-21 18:31:12 -04:00
2010-04-30 14:52:51 -05:00
2010-08-09 16:48:42 -04:00
2010-08-09 16:48:24 -04:00
2009-10-27 19:34:04 -04:00
2010-08-09 16:48:45 -04:00
2010-08-09 16:48:45 -04:00
2010-08-09 16:48:45 -04:00
2010-08-09 16:48:01 -04:00
2010-08-09 16:48:37 -04:00
2010-06-01 13:32:11 -07:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:48:35 -04:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:48:15 -04:00
2010-08-09 16:48:17 -04:00
2010-08-09 16:48:16 -04:00
2010-08-09 16:47:49 -04:00
2010-05-27 09:12:56 -07:00
2010-05-21 19:30:41 +02:00
2010-07-15 15:17:47 -07:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:48:17 -04:00
2010-03-30 22:02:32 +09:00
2010-08-09 16:48:35 -04:00
2010-08-09 16:47:53 -04:00
2010-08-09 16:48:20 -04:00
2010-08-09 16:48:37 -04:00
2010-03-30 22:02:32 +09:00
2010-08-09 16:48:42 -04:00
2010-08-09 16:48:25 -04:00
2009-09-30 09:31:14 -07:00
2010-08-09 16:47:44 -04:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:48:05 -04:00
2010-07-19 09:22:50 +02:00
2010-08-09 16:47:52 -04:00
2010-08-09 16:47:31 -04:00
2010-08-09 16:47:44 -04:00
2010-08-09 16:47:39 -04:00
2010-08-09 16:48:23 -04:00
2010-01-26 22:22:26 -05:00
2010-08-09 16:48:00 -04:00
2010-05-23 08:27:42 +01:00
2010-08-09 16:47:53 -04:00
2010-08-09 16:47:59 -04:00
2010-08-09 16:48:18 -04:00
2010-08-09 16:48:19 -04:00
2010-08-09 16:48:02 -04:00
2010-08-09 16:48:37 -04:00
2010-05-27 22:03:07 -04:00
2010-05-27 22:03:05 -04:00
2010-08-09 16:47:39 -04:00
2010-05-27 22:05:02 -04:00
2010-03-30 22:02:32 +09:00
2010-06-01 08:11:06 -07:00
2010-03-06 11:26:46 -08:00
2010-03-30 22:02:32 +09:00
2010-06-29 15:29:31 -07:00
2010-08-09 16:48:37 -04:00
2010-03-30 22:02:32 +09:00
2010-01-29 08:22:01 -08:00
2010-03-30 22:02:32 +09:00
2010-03-19 08:05:10 +01:00
2010-08-09 16:48:37 -04:00
2010-08-09 16:47:33 -04:00
2009-09-24 07:21:03 -07:00
2010-03-06 11:26:45 -08:00
2010-04-29 08:44:37 -07:00
2010-08-09 16:48:42 -04:00
2010-08-09 16:48:13 -04:00
2010-08-09 16:47:29 -04:00
2010-08-09 16:47:44 -04:00
2010-03-30 22:02:32 +09:00
2010-05-11 17:43:58 +02:00
2010-05-27 09:12:46 -07:00
2010-06-29 15:29:32 -07:00
2010-03-30 22:02:32 +09:00
2010-05-27 22:03:07 -04:00
2010-03-06 11:26:29 -08:00
2010-03-30 22:02:32 +09:00
2010-08-09 16:47:44 -04:00
2010-05-21 18:31:18 -04:00
2010-08-09 16:48:39 -04:00
2010-05-21 18:31:16 -04:00
2010-05-21 18:31:18 -04:00
2010-03-30 22:02:32 +09:00
2010-03-19 09:43:06 -07:00
2010-08-09 16:47:39 -04:00
2010-03-08 16:55:37 +01:00
2010-05-21 18:31:17 -04:00
2010-08-09 16:48:47 -04:00
2010-03-30 22:02:32 +09:00
2010-05-27 22:03:06 -04:00
2010-05-18 08:57:00 +10:00
2010-03-03 13:00:21 -05:00
2010-05-21 18:31:17 -04:00
2010-06-10 19:08:34 +02:00
2010-03-03 13:00:22 -05:00
2010-03-03 14:07:55 -05:00
2010-05-27 09:12:56 -07:00
2010-03-12 15:52:32 -08:00
2010-03-07 15:48:26 -08:00
2010-03-30 22:02:32 +09:00
2010-06-30 08:12:37 +02:00
2009-12-17 10:58:17 -05:00
2009-12-23 13:33:54 +01:00
2010-08-09 16:48:44 -04:00
2010-06-29 10:38:22 -07:00
2010-08-09 16:47:43 -04:00
2010-05-20 13:21:42 -07:00
2010-03-30 22:02:32 +09:00
2010-05-21 18:31:18 -04:00