Hou Tao 27abc7b3fa bpf: Fix exact match conditions in trie_get_next_key()
trie_get_next_key() uses node->prefixlen == key->prefixlen to identify
an exact match, However, it is incorrect because when the target key
doesn't fully match the found node (e.g., node->prefixlen != matchlen),
these two nodes may also have the same prefixlen. It will return
expected result when the passed key exist in the trie. However when a
recently-deleted key or nonexistent key is passed to
trie_get_next_key(), it may skip keys and return incorrect result.

Fix it by using node->prefixlen == matchlen to identify exact matches.
When the condition is true after the search, it also implies
node->prefixlen equals key->prefixlen, otherwise, the search would
return NULL instead.

Fixes: b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map")
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Hou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/20241206110622.1161752-6-houtao@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
2024-12-06 09:14:26 -08:00
..
2024-11-21 08:11:04 -08:00
2024-11-21 08:11:04 -08:00
2024-08-30 08:55:26 -07:00
2024-08-30 08:55:26 -07:00
2024-11-22 20:36:11 -08:00
2024-11-21 08:11:04 -08:00
2022-05-10 11:20:45 -07:00
2024-08-30 08:55:26 -07:00
2024-08-30 08:57:47 -07:00
2024-10-22 15:42:56 -07:00
2024-11-22 13:27:01 -08:00
2024-11-18 10:30:29 -08:00
2023-10-23 15:01:53 -07:00