mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-06 05:13:18 +00:00
dc93f0dcb4
During mt8195_afe_init_clock(), mt8195_audsys_clk_register() was called
followed by several other devm functions. At mt8195_afe_deinit_clock()
located at mt8195_afe_pcm_dev_remove(), mt8195_audsys_clk_unregister()
was called.
However, there was an issue with the order in which these functions were
called. Specifically, the remove callback of platform_driver was called
before devres released the resource, resulting in a use-after-free issue
during remove time.
At probe time, the order of calls was:
1. mt8195_audsys_clk_register
2. afe_priv->clk = devm_kcalloc
3. afe_priv->clk[i] = devm_clk_get
At remove time, the order of calls was:
1. mt8195_audsys_clk_unregister
3. free afe_priv->clk[i]
2. free afe_priv->clk
To resolve the problem, we can utilize devm_add_action_or_reset() in
mt8195_audsys_clk_register() so that the remove order can be changed to
3->2->1.
Fixes: 6746cc8582 ("ASoC: mediatek: mt8195: add platform driver")
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230601033318.10408-3-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
120 lines
3.3 KiB
C
120 lines
3.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* mt8195-afe-clk.h -- Mediatek 8195 afe clock ctrl definition
|
|
*
|
|
* Copyright (c) 2021 MediaTek Inc.
|
|
* Author: Bicycle Tsai <bicycle.tsai@mediatek.com>
|
|
* Trevor Wu <trevor.wu@mediatek.com>
|
|
*/
|
|
|
|
#ifndef _MT8195_AFE_CLK_H_
|
|
#define _MT8195_AFE_CLK_H_
|
|
|
|
enum {
|
|
/* xtal */
|
|
MT8195_CLK_XTAL_26M,
|
|
/* divider */
|
|
MT8195_CLK_TOP_APLL1,
|
|
MT8195_CLK_TOP_APLL2,
|
|
MT8195_CLK_TOP_APLL12_DIV0,
|
|
MT8195_CLK_TOP_APLL12_DIV1,
|
|
MT8195_CLK_TOP_APLL12_DIV2,
|
|
MT8195_CLK_TOP_APLL12_DIV3,
|
|
MT8195_CLK_TOP_APLL12_DIV9,
|
|
/* mux */
|
|
MT8195_CLK_TOP_A1SYS_HP_SEL,
|
|
MT8195_CLK_TOP_AUD_INTBUS_SEL,
|
|
MT8195_CLK_TOP_AUDIO_H_SEL,
|
|
MT8195_CLK_TOP_AUDIO_LOCAL_BUS_SEL,
|
|
MT8195_CLK_TOP_DPTX_M_SEL,
|
|
MT8195_CLK_TOP_I2SO1_M_SEL,
|
|
MT8195_CLK_TOP_I2SO2_M_SEL,
|
|
MT8195_CLK_TOP_I2SI1_M_SEL,
|
|
MT8195_CLK_TOP_I2SI2_M_SEL,
|
|
/* clock gate */
|
|
MT8195_CLK_INFRA_AO_AUDIO_26M_B,
|
|
MT8195_CLK_SCP_ADSP_AUDIODSP,
|
|
MT8195_CLK_AUD_AFE,
|
|
MT8195_CLK_AUD_APLL1_TUNER,
|
|
MT8195_CLK_AUD_APLL2_TUNER,
|
|
MT8195_CLK_AUD_APLL,
|
|
MT8195_CLK_AUD_APLL2,
|
|
MT8195_CLK_AUD_DAC,
|
|
MT8195_CLK_AUD_ADC,
|
|
MT8195_CLK_AUD_DAC_HIRES,
|
|
MT8195_CLK_AUD_A1SYS_HP,
|
|
MT8195_CLK_AUD_ADC_HIRES,
|
|
MT8195_CLK_AUD_ADDA6_ADC,
|
|
MT8195_CLK_AUD_ADDA6_ADC_HIRES,
|
|
MT8195_CLK_AUD_I2SIN,
|
|
MT8195_CLK_AUD_TDM_IN,
|
|
MT8195_CLK_AUD_I2S_OUT,
|
|
MT8195_CLK_AUD_TDM_OUT,
|
|
MT8195_CLK_AUD_HDMI_OUT,
|
|
MT8195_CLK_AUD_ASRC11,
|
|
MT8195_CLK_AUD_ASRC12,
|
|
MT8195_CLK_AUD_A1SYS,
|
|
MT8195_CLK_AUD_A2SYS,
|
|
MT8195_CLK_AUD_PCMIF,
|
|
MT8195_CLK_AUD_MEMIF_UL1,
|
|
MT8195_CLK_AUD_MEMIF_UL2,
|
|
MT8195_CLK_AUD_MEMIF_UL3,
|
|
MT8195_CLK_AUD_MEMIF_UL4,
|
|
MT8195_CLK_AUD_MEMIF_UL5,
|
|
MT8195_CLK_AUD_MEMIF_UL6,
|
|
MT8195_CLK_AUD_MEMIF_UL8,
|
|
MT8195_CLK_AUD_MEMIF_UL9,
|
|
MT8195_CLK_AUD_MEMIF_UL10,
|
|
MT8195_CLK_AUD_MEMIF_DL2,
|
|
MT8195_CLK_AUD_MEMIF_DL3,
|
|
MT8195_CLK_AUD_MEMIF_DL6,
|
|
MT8195_CLK_AUD_MEMIF_DL7,
|
|
MT8195_CLK_AUD_MEMIF_DL8,
|
|
MT8195_CLK_AUD_MEMIF_DL10,
|
|
MT8195_CLK_AUD_MEMIF_DL11,
|
|
MT8195_CLK_NUM,
|
|
};
|
|
|
|
enum {
|
|
MT8195_MCK_SEL_26M,
|
|
MT8195_MCK_SEL_APLL1,
|
|
MT8195_MCK_SEL_APLL2,
|
|
MT8195_MCK_SEL_APLL3,
|
|
MT8195_MCK_SEL_APLL4,
|
|
MT8195_MCK_SEL_APLL5,
|
|
MT8195_MCK_SEL_HDMIRX_APLL,
|
|
MT8195_MCK_SEL_NUM,
|
|
};
|
|
|
|
enum {
|
|
MT8195_AUD_PLL1,
|
|
MT8195_AUD_PLL2,
|
|
MT8195_AUD_PLL3,
|
|
MT8195_AUD_PLL4,
|
|
MT8195_AUD_PLL5,
|
|
MT8195_AUD_PLL_NUM,
|
|
};
|
|
|
|
struct mtk_base_afe;
|
|
|
|
int mt8195_afe_get_mclk_source_clk_id(int sel);
|
|
int mt8195_afe_get_mclk_source_rate(struct mtk_base_afe *afe, int apll);
|
|
int mt8195_afe_get_default_mclk_source_by_rate(int rate);
|
|
int mt8195_afe_init_clock(struct mtk_base_afe *afe);
|
|
int mt8195_afe_enable_clk(struct mtk_base_afe *afe, struct clk *clk);
|
|
void mt8195_afe_disable_clk(struct mtk_base_afe *afe, struct clk *clk);
|
|
int mt8195_afe_prepare_clk(struct mtk_base_afe *afe, struct clk *clk);
|
|
void mt8195_afe_unprepare_clk(struct mtk_base_afe *afe, struct clk *clk);
|
|
int mt8195_afe_enable_clk_atomic(struct mtk_base_afe *afe, struct clk *clk);
|
|
void mt8195_afe_disable_clk_atomic(struct mtk_base_afe *afe, struct clk *clk);
|
|
int mt8195_afe_set_clk_rate(struct mtk_base_afe *afe, struct clk *clk,
|
|
unsigned int rate);
|
|
int mt8195_afe_set_clk_parent(struct mtk_base_afe *afe, struct clk *clk,
|
|
struct clk *parent);
|
|
int mt8195_afe_enable_main_clock(struct mtk_base_afe *afe);
|
|
int mt8195_afe_disable_main_clock(struct mtk_base_afe *afe);
|
|
int mt8195_afe_enable_reg_rw_clk(struct mtk_base_afe *afe);
|
|
int mt8195_afe_disable_reg_rw_clk(struct mtk_base_afe *afe);
|
|
|
|
#endif
|