Lucas De Marchi
514447a121
drm/xe: Stop accumulating LRC timestamp on job_free ...
The exec queue timestamp is only really useful when it's being queried
through the fdinfo. There's no need to update it so often, on every
job_free. Tracing a simple app like vkcube running shows an update
rate of ~ 120Hz. In case of discrete, the BO is on vram, creating a lot
of pcie transactions.
The update on job_free() is used to cover a gap: if exec
queue is created and destroyed rapidly, before a new query, the
timestamp still needs to be accumulated and accounted for in the xef.
Initial implementation in commit 6109f24f87d7 ("drm/xe: Add helper to
accumulate exec queue runtime") couldn't do it on the exec_queue_fini
since the xef could be gone at that point. However since commit
ce8c161cbad4 ("drm/xe: Add ref counting for xe_file") the xef is
refcounted and the exec queue always holds a reference, making this safe
now.
Improve the fix in commit 2149ded63079 ("drm/xe: Fix use after free when
client stats are captured") by reducing the frequency in which the
update is needed.
Fixes: 2149ded63079 ("drm/xe: Fix use after free when client stats are captured")
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241104143815.2112272-3-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit 83db047d9425d9a649f01573797558eff0f632e1)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
2024-11-05 15:40:13 -08:00
2024-08-08 13:47:27 -07:00
2024-09-12 10:06:55 -04:00
2024-10-29 07:12:56 -07:00
2024-06-18 12:40:38 -07:00
2024-11-04 08:03:40 -08:00
2024-08-28 15:17:54 -04:00
2023-12-21 16:31:30 -05:00
2024-06-12 11:31:42 -04:00
2024-05-23 13:38:26 -04:00
2023-12-21 11:40:20 -05:00
2024-08-29 10:32:20 -07:00
2024-05-09 21:28:25 +02:00
2024-09-03 11:42:42 +02:00
2024-09-17 23:31:59 -05:00
2023-12-21 11:40:27 -05:00
2024-04-02 10:33:57 -07:00
2024-08-22 14:00:45 -04:00
2024-10-03 01:24:22 -05:00
2024-09-17 23:31:06 -05:00
2024-10-08 18:06:24 -05:00
2024-08-09 21:15:14 -07:00
2024-08-01 11:00:14 -07:00
2024-08-01 11:00:14 -07:00
2024-04-11 09:39:48 -04:00
2024-05-22 13:22:38 +01:00
2024-04-18 13:30:24 -07:00
2024-11-04 08:12:30 -08:00
2024-11-04 08:12:30 -08:00
2024-11-04 08:12:30 -08:00
2024-04-02 10:33:57 -07:00
2024-10-03 01:21:55 -05:00
2023-12-21 11:41:15 -05:00
2024-08-27 14:09:45 +02:00
2024-11-05 15:40:13 -08:00
2024-08-17 18:31:54 -07:00
2024-11-05 15:40:12 -08:00
2024-08-28 14:50:13 -04:00
2024-08-28 14:50:13 -04:00
2023-12-21 11:37:31 -05:00
2023-12-21 11:41:13 -05:00
2024-10-24 12:42:52 -05:00
2024-06-10 14:18:27 -04:00
2024-07-29 11:19:40 -07:00
2024-08-22 14:00:45 -04:00
2024-10-31 07:02:42 -07:00
2024-08-22 14:00:45 -04:00
2024-10-03 01:19:44 -05:00
2024-10-16 09:00:22 -05:00
2024-08-29 10:32:20 -07:00
2024-08-29 10:32:20 -07:00
2024-08-16 09:15:04 -07:00
2024-03-06 09:50:48 +02:00
2024-05-07 23:21:15 +02:00
2024-03-06 09:50:49 +02:00
2024-03-14 14:47:13 -07:00
2024-09-03 10:36:38 -04:00
2024-08-29 10:32:20 -07:00
2024-11-04 08:12:30 -08:00
2024-04-24 10:19:52 -05:00
2024-06-12 19:10:22 -07:00
2024-06-12 19:10:22 -07:00
2024-08-16 11:07:11 -07:00
2024-03-29 14:00:06 +01:00
2024-10-03 01:13:54 -05:00
2024-04-18 13:26:34 -07:00
2023-12-21 11:45:08 -05:00
2024-06-20 19:49:40 +02:00
2024-05-28 12:29:43 -04:00
2024-10-03 01:13:55 -05:00
2024-05-31 00:02:04 +02:00
2024-10-03 01:13:55 -05:00
2024-05-03 13:15:54 -07:00
2024-08-22 14:00:45 -04:00
2024-11-05 15:40:12 -08:00
2024-08-30 10:51:06 +02:00
2024-08-30 10:51:09 +02:00
2024-08-30 10:51:09 +02:00
2024-08-30 10:51:09 +02:00
2024-05-16 18:04:54 +02:00
2024-04-24 15:18:38 +02:00
2024-04-12 16:23:28 +02:00
2024-05-16 18:04:51 +02:00
2024-05-16 18:04:51 +02:00
2024-05-16 18:04:51 +02:00
2024-04-12 16:23:37 +02:00
2024-04-22 09:03:09 -04:00
2024-04-12 16:23:37 +02:00
2024-04-24 15:10:42 +02:00
2024-04-24 15:10:46 +02:00
2024-04-24 15:10:42 +02:00
2024-08-30 10:51:09 +02:00
2024-08-30 10:51:09 +02:00
2024-07-01 19:43:52 +02:00
2024-01-05 16:25:53 +01:00
2024-05-16 20:18:39 +02:00
2024-05-16 20:18:39 +02:00
2024-05-24 10:08:41 +02:00
2024-08-22 14:00:45 -04:00
2024-07-15 15:18:34 +02:00
2024-08-12 19:08:53 +02:00
2024-08-12 19:08:53 +02:00
2024-10-03 01:13:54 -05:00
2024-04-18 13:26:34 -07:00
2024-05-23 10:55:28 -07:00
2024-05-23 10:55:28 -07:00
2024-08-15 09:44:22 -04:00
2024-11-04 08:12:30 -08:00
2024-10-16 09:00:22 -05:00
2024-07-22 09:43:52 -07:00
2024-04-24 09:06:38 -07:00
2024-09-03 10:36:46 -04:00
2024-10-16 09:00:22 -05:00
2024-09-01 20:43:33 -07:00
2024-04-09 12:54:02 +02:00
2024-08-08 13:47:27 -07:00
2024-05-13 21:36:50 +02:00
2024-06-07 12:24:30 +02:00
2024-11-04 08:12:30 -08:00
2024-07-01 17:38:48 +02:00
2024-04-24 18:18:02 +02:00
2023-12-21 16:31:29 -05:00
2024-02-26 09:06:45 -05:00
2023-12-21 11:39:20 -05:00
2024-04-09 12:54:02 +02:00
2024-08-16 11:07:13 -07:00
2024-08-16 11:07:13 -07:00
2024-01-05 16:25:53 +01:00
2024-07-02 18:33:19 +02:00
2024-03-27 20:19:25 +01:00
2024-05-16 18:04:41 +02:00
2024-05-16 18:04:38 +02:00
2024-05-16 18:04:39 +02:00
2024-05-16 18:04:39 +02:00
2024-04-02 10:33:57 -07:00
2024-06-26 18:23:45 -04:00
2024-09-03 10:36:46 -04:00
2024-06-26 18:23:45 -04:00
2024-01-05 16:25:53 +01:00
2024-06-05 09:52:13 +02:00
2024-01-05 16:25:53 +01:00
2024-03-04 12:23:12 +01:00
2024-11-05 15:40:13 -08:00
2024-07-18 10:25:33 -04:00
2024-10-11 09:03:30 +10:00
2024-08-23 09:54:11 -07:00
2024-09-17 23:22:24 -05:00
2024-07-17 09:47:15 -07:00
2024-07-17 09:47:15 -07:00
2024-04-12 14:49:03 +02:00
2024-04-12 14:49:03 +02:00
2024-02-26 09:06:45 -05:00
2023-12-21 11:45:24 -05:00
2024-08-16 09:15:04 -07:00
2024-05-22 12:03:55 +02:00
2024-05-22 13:22:38 +01:00
2024-02-26 09:06:45 -05:00
2024-08-17 18:31:47 -07:00
2024-08-17 18:31:57 -07:00
2024-08-17 18:31:57 -07:00
2024-08-28 14:50:13 -04:00
2024-08-28 15:17:54 -04:00
2024-08-06 22:21:14 -07:00
2024-08-21 11:53:12 -04:00
2024-08-21 11:53:12 -04:00
2024-05-27 21:26:02 +02:00
2024-09-03 10:36:46 -04:00
2023-12-21 11:42:08 -05:00
2024-07-17 09:47:15 -07:00
2024-06-26 18:25:22 -04:00
2023-12-21 11:45:27 -05:00
2023-12-21 11:45:27 -05:00
2023-12-21 11:45:27 -05:00
2024-07-22 12:53:04 +02:00
2023-12-21 11:45:27 -05:00
2024-05-29 23:44:41 -07:00
2024-08-26 10:27:33 +02:00
2024-06-18 12:40:38 -07:00
2023-12-21 11:39:17 -05:00
2023-12-21 11:37:52 -05:00
2023-12-21 16:31:29 -05:00
2024-04-02 10:33:57 -07:00
2023-12-21 16:31:29 -05:00
2024-08-28 15:17:54 -04:00
2024-08-22 14:00:44 -04:00
2024-08-27 14:09:45 +02:00
2024-07-25 16:53:33 -07:00
2024-06-28 14:00:09 -07:00
2024-05-07 12:03:49 +02:00
2024-08-28 16:29:15 +02:00
2024-08-13 13:52:20 -07:00
2024-08-28 15:17:54 -04:00
2024-10-03 01:23:18 -05:00
2024-06-18 12:40:32 -07:00
2024-08-28 15:17:54 -04:00
2024-07-11 09:54:24 -04:00
2024-08-28 15:17:54 -04:00
2023-12-21 11:45:07 -05:00
2024-07-01 19:43:50 +02:00
2024-07-01 18:01:31 +02:00
2024-05-08 14:48:30 -07:00
2024-10-03 01:13:54 -05:00
2024-01-09 17:47:24 -05:00
2024-09-03 10:36:46 -04:00
2024-09-03 10:36:46 -04:00
2024-04-09 14:17:39 -07:00
2024-10-29 07:12:55 -07:00
2024-09-04 09:28:09 +02:00
2024-08-19 10:39:28 -04:00
2024-08-27 14:09:45 +02:00
2023-12-21 11:39:20 -05:00
2024-07-03 22:28:04 -07:00
2024-02-15 09:53:18 +01:00
2024-02-15 09:53:18 +01:00
2024-10-03 01:24:54 -05:00
2024-07-03 22:28:04 -07:00
2024-10-16 09:00:22 -05:00
2024-02-15 09:53:38 +01:00
2023-12-21 11:37:52 -05:00
2024-02-09 11:52:28 +02:00
2024-05-13 21:36:52 +02:00
2024-06-18 12:40:42 -07:00
2024-08-22 14:00:44 -04:00
2024-06-13 11:36:23 +02:00
2024-07-29 11:19:40 -07:00
2024-06-18 12:03:29 -07:00
2024-08-28 15:17:54 -04:00
2024-07-29 11:19:40 -07:00
2024-08-23 09:54:32 -07:00
2024-08-23 09:54:32 -07:00
2024-05-27 21:26:03 +02:00
2024-08-28 15:17:54 -04:00
2024-06-14 16:51:43 -04:00
2024-04-12 16:23:28 +02:00
2024-04-12 16:23:26 +02:00
2024-04-12 16:23:26 +02:00
2023-12-21 11:45:27 -05:00
2024-04-12 16:23:26 +02:00
2024-07-04 11:54:35 +02:00
2024-06-18 10:51:59 +02:00
2024-08-22 15:48:21 +03:00
2024-08-22 15:48:21 +03:00
2023-12-21 11:45:24 -05:00
2024-02-29 10:39:02 +01:00
2024-10-24 12:42:52 -05:00
2024-07-18 10:17:30 -07:00
2024-05-22 13:22:38 +01:00
2024-04-18 13:30:17 -07:00
2024-09-03 10:36:46 -04:00
2023-12-21 11:45:10 -05:00
2024-06-12 09:25:07 -07:00
2024-07-03 22:28:06 -07:00
2024-06-12 09:25:10 -07:00
2024-06-12 09:25:12 -07:00
2023-12-21 11:43:34 -05:00
2024-08-27 14:09:45 +02:00
2024-08-22 14:00:44 -04:00
2024-08-28 06:45:52 -07:00
2023-12-21 11:43:32 -05:00
2024-08-07 18:19:00 -04:00
2024-04-16 12:37:31 +02:00
2024-10-03 01:13:55 -05:00
2023-12-21 11:42:10 -05:00
2024-08-29 10:32:20 -07:00
2023-12-21 11:45:06 -05:00
2024-04-08 14:58:52 +02:00
2024-08-29 10:32:19 -07:00
2024-09-03 10:36:38 -04:00
2023-12-21 11:45:06 -05:00
2024-07-18 10:25:33 -04:00
2024-07-18 10:25:33 -04:00
2024-05-07 12:45:39 -04:00
2024-07-03 22:28:07 -07:00
2024-10-16 09:00:22 -05:00
2024-07-03 22:28:04 -07:00
2024-09-03 10:36:46 -04:00
2024-04-18 13:30:17 -07:00
2024-09-17 23:22:28 -05:00
2024-05-30 23:50:28 +02:00
2024-08-19 13:30:41 -04:00
2024-10-16 09:00:22 -05:00
2024-07-24 09:05:37 -07:00
2024-11-04 08:12:30 -08:00
2024-01-23 16:54:41 +01:00
2023-12-21 11:44:39 -05:00
514447a121