Robert Varga 657e9649e7 tcp: fix CONFIG_TCP_MD5SIG + CONFIG_PREEMPT timer BUG()
I have recently came across a preemption imbalance detected by:

<4>huh, entered ffffffff80644630 with preempt_count 00000102, exited with 00000101?
<0>------------[ cut here ]------------
<2>kernel BUG at /usr/src/linux/kernel/timer.c:664!
<0>invalid opcode: 0000 [1] PREEMPT SMP

with ffffffff80644630 being inet_twdr_hangman().

This appeared after I enabled CONFIG_TCP_MD5SIG and played with it a
bit, so I looked at what might have caused it.

One thing that struck me as strange is tcp_twsk_destructor(), as it
calls tcp_put_md5sig_pool() -- which entails a put_cpu(), causing the
detected imbalance. Found on 2.6.23.9, but 2.6.31 is affected as well,
as far as I can tell.

Signed-off-by: Robert Varga <nite@hq.alert.sk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-09-15 23:49:21 -07:00
..
2009-09-14 17:03:01 -07:00
2009-09-14 17:03:01 -07:00
2009-09-01 17:40:57 -07:00
2008-07-16 20:20:11 -07:00
2009-09-14 17:03:01 -07:00
2009-08-28 23:57:15 -07:00
2009-09-14 17:03:01 -07:00
2009-06-03 02:51:04 -07:00
2009-09-14 17:03:01 -07:00
2009-09-14 17:03:01 -07:00
2009-06-03 02:51:04 -07:00
2009-06-03 02:51:02 -07:00
2009-09-14 17:03:01 -07:00
2009-09-14 17:03:01 -07:00
2009-06-13 23:36:32 -07:00
2008-10-07 08:38:24 +11:00
2009-06-03 02:51:04 -07:00
2009-04-27 02:45:02 -07:00
2009-09-14 17:03:01 -07:00
2009-09-02 18:05:33 -07:00
2008-11-03 18:21:05 -08:00
2009-03-02 03:00:15 -08:00
2009-03-02 03:00:15 -08:00
2009-03-02 03:00:14 -08:00
2009-09-15 01:30:10 -07:00
2009-09-15 01:30:10 -07:00
2009-03-13 16:05:14 -07:00
2009-05-25 22:44:59 -07:00
2009-03-02 03:00:15 -08:00
2009-03-02 03:00:15 -08:00
2009-09-15 01:30:10 -07:00
2009-09-14 17:03:01 -07:00
2009-09-02 18:05:33 -07:00
2009-09-14 17:03:01 -07:00
2009-06-03 02:51:04 -07:00
2009-06-03 02:51:04 -07:00
2009-06-03 02:51:04 -07:00