mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-06 05:13:18 +00:00
6c857ccf4e
When voltage-ranges property is not present the driver assumes that
it is 3.3v (3.2v..3.4v). But at the same time it disallows polling.
Fix that by dropping the comparison to 0 when no property is provided.
While at it, mark voltage-ranges property optional as it was initially.
Fixes: 9c43df5791 ("mmc_spi: Add support for OpenFirmware bindings")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210419112459.25241-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
101 lines
2.3 KiB
C
101 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* OpenFirmware bindings for the MMC-over-SPI driver
|
|
*
|
|
* Copyright (c) MontaVista Software, Inc. 2008.
|
|
*
|
|
* Author: Anton Vorontsov <avorontsov@ru.mvista.com>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/spi/spi.h>
|
|
#include <linux/spi/mmc_spi.h>
|
|
#include <linux/mmc/core.h>
|
|
#include <linux/mmc/host.h>
|
|
|
|
/* For archs that don't support NO_IRQ (such as mips), provide a dummy value */
|
|
#ifndef NO_IRQ
|
|
#define NO_IRQ 0
|
|
#endif
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
struct of_mmc_spi {
|
|
int detect_irq;
|
|
struct mmc_spi_platform_data pdata;
|
|
};
|
|
|
|
static struct of_mmc_spi *to_of_mmc_spi(struct device *dev)
|
|
{
|
|
return container_of(dev->platform_data, struct of_mmc_spi, pdata);
|
|
}
|
|
|
|
static int of_mmc_spi_init(struct device *dev,
|
|
irqreturn_t (*irqhandler)(int, void *), void *mmc)
|
|
{
|
|
struct of_mmc_spi *oms = to_of_mmc_spi(dev);
|
|
|
|
return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
|
|
IRQF_ONESHOT, dev_name(dev), mmc);
|
|
}
|
|
|
|
static void of_mmc_spi_exit(struct device *dev, void *mmc)
|
|
{
|
|
struct of_mmc_spi *oms = to_of_mmc_spi(dev);
|
|
|
|
free_irq(oms->detect_irq, mmc);
|
|
}
|
|
|
|
struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
|
|
{
|
|
struct mmc_host *mmc = dev_get_drvdata(&spi->dev);
|
|
struct device *dev = &spi->dev;
|
|
struct device_node *np = dev->of_node;
|
|
struct of_mmc_spi *oms;
|
|
|
|
if (dev->platform_data || !np)
|
|
return dev->platform_data;
|
|
|
|
oms = kzalloc(sizeof(*oms), GFP_KERNEL);
|
|
if (!oms)
|
|
return NULL;
|
|
|
|
if (mmc_of_parse_voltage(mmc, &oms->pdata.ocr_mask) < 0)
|
|
goto err_ocr;
|
|
|
|
oms->detect_irq = irq_of_parse_and_map(np, 0);
|
|
if (oms->detect_irq != 0) {
|
|
oms->pdata.init = of_mmc_spi_init;
|
|
oms->pdata.exit = of_mmc_spi_exit;
|
|
} else {
|
|
oms->pdata.caps |= MMC_CAP_NEEDS_POLL;
|
|
}
|
|
|
|
dev->platform_data = &oms->pdata;
|
|
return dev->platform_data;
|
|
err_ocr:
|
|
kfree(oms);
|
|
return NULL;
|
|
}
|
|
EXPORT_SYMBOL(mmc_spi_get_pdata);
|
|
|
|
void mmc_spi_put_pdata(struct spi_device *spi)
|
|
{
|
|
struct device *dev = &spi->dev;
|
|
struct device_node *np = dev->of_node;
|
|
struct of_mmc_spi *oms = to_of_mmc_spi(dev);
|
|
|
|
if (!dev->platform_data || !np)
|
|
return;
|
|
|
|
kfree(oms);
|
|
dev->platform_data = NULL;
|
|
}
|
|
EXPORT_SYMBOL(mmc_spi_put_pdata);
|