mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-14 17:14:09 +00:00
eb336eab3e
au0828 IR stop and poll routines continue to access device while usb disconnect is in progress. There is small window between device disconnect and usb interface is set to null. This results in filling the log with several of the following error messages. Fix it to detect device disconnect condition and avoid device access. Nov 20 18:58:02 anduin kernel: [ 102.949819] au0828: au0828_usb_disconnect() Nov 20 18:58:02 anduin kernel: [ 102.950046] au0828: send_control_msg() Failed sending control message, error -71. Nov 20 18:58:02 anduin kernel: [ 102.950052] au0828: send_control_msg() Failed sending control message, error -19. Nov 20 18:58:02 anduin kernel: [ 102.950056] au0828: send_control_msg() Failed sending control message, error -19. Nov 20 18:58:02 anduin kernel: [ 102.950061] au0828: send_control_msg() Failed sending control message, error -19. Nov 20 18:58:02 anduin kernel: [ 102.950065] au0828: recv_control_msg() Failed receiving control message, error -19. Nov 20 18:58:02 anduin kernel: [ 102.950069] au0828: recv_control_msg() Failed receiving control message, error -19. Nov 20 18:58:02 anduin kernel: [ 102.950072] au0828: recv_control_msg() Failed receiving control message, error -19. Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
385 lines
9.2 KiB
C
385 lines
9.2 KiB
C
/*
|
|
* Driver for the Auvitek USB bridge
|
|
*
|
|
* Copyright (c) 2008 Steven Toth <stoth@linuxtv.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
*
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#include "au0828.h"
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/videodev2.h>
|
|
#include <media/v4l2-common.h>
|
|
#include <linux/mutex.h>
|
|
|
|
/*
|
|
* 1 = General debug messages
|
|
* 2 = USB handling
|
|
* 4 = I2C related
|
|
* 8 = Bridge related
|
|
* 16 = IR related
|
|
*/
|
|
int au0828_debug;
|
|
module_param_named(debug, au0828_debug, int, 0644);
|
|
MODULE_PARM_DESC(debug,
|
|
"set debug bitmask: 1=general, 2=USB, 4=I2C, 8=bridge, 16=IR");
|
|
|
|
static unsigned int disable_usb_speed_check;
|
|
module_param(disable_usb_speed_check, int, 0444);
|
|
MODULE_PARM_DESC(disable_usb_speed_check,
|
|
"override min bandwidth requirement of 480M bps");
|
|
|
|
#define _AU0828_BULKPIPE 0x03
|
|
#define _BULKPIPESIZE 0xffff
|
|
|
|
static int send_control_msg(struct au0828_dev *dev, u16 request, u32 value,
|
|
u16 index);
|
|
static int recv_control_msg(struct au0828_dev *dev, u16 request, u32 value,
|
|
u16 index, unsigned char *cp, u16 size);
|
|
|
|
/* USB Direction */
|
|
#define CMD_REQUEST_IN 0x00
|
|
#define CMD_REQUEST_OUT 0x01
|
|
|
|
u32 au0828_readreg(struct au0828_dev *dev, u16 reg)
|
|
{
|
|
u8 result = 0;
|
|
|
|
recv_control_msg(dev, CMD_REQUEST_IN, 0, reg, &result, 1);
|
|
dprintk(8, "%s(0x%04x) = 0x%02x\n", __func__, reg, result);
|
|
|
|
return result;
|
|
}
|
|
|
|
u32 au0828_writereg(struct au0828_dev *dev, u16 reg, u32 val)
|
|
{
|
|
dprintk(8, "%s(0x%04x, 0x%02x)\n", __func__, reg, val);
|
|
return send_control_msg(dev, CMD_REQUEST_OUT, val, reg);
|
|
}
|
|
|
|
static int send_control_msg(struct au0828_dev *dev, u16 request, u32 value,
|
|
u16 index)
|
|
{
|
|
int status = -ENODEV;
|
|
|
|
if (dev->usbdev) {
|
|
|
|
/* cp must be memory that has been allocated by kmalloc */
|
|
status = usb_control_msg(dev->usbdev,
|
|
usb_sndctrlpipe(dev->usbdev, 0),
|
|
request,
|
|
USB_DIR_OUT | USB_TYPE_VENDOR |
|
|
USB_RECIP_DEVICE,
|
|
value, index, NULL, 0, 1000);
|
|
|
|
status = min(status, 0);
|
|
|
|
if (status < 0) {
|
|
pr_err("%s() Failed sending control message, error %d.\n",
|
|
__func__, status);
|
|
}
|
|
|
|
}
|
|
|
|
return status;
|
|
}
|
|
|
|
static int recv_control_msg(struct au0828_dev *dev, u16 request, u32 value,
|
|
u16 index, unsigned char *cp, u16 size)
|
|
{
|
|
int status = -ENODEV;
|
|
mutex_lock(&dev->mutex);
|
|
if (dev->usbdev) {
|
|
status = usb_control_msg(dev->usbdev,
|
|
usb_rcvctrlpipe(dev->usbdev, 0),
|
|
request,
|
|
USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
|
|
value, index,
|
|
dev->ctrlmsg, size, 1000);
|
|
|
|
status = min(status, 0);
|
|
|
|
if (status < 0) {
|
|
pr_err("%s() Failed receiving control message, error %d.\n",
|
|
__func__, status);
|
|
}
|
|
|
|
/* the host controller requires heap allocated memory, which
|
|
is why we didn't just pass "cp" into usb_control_msg */
|
|
memcpy(cp, dev->ctrlmsg, size);
|
|
}
|
|
mutex_unlock(&dev->mutex);
|
|
return status;
|
|
}
|
|
|
|
static void au0828_usb_release(struct au0828_dev *dev)
|
|
{
|
|
/* I2C */
|
|
au0828_i2c_unregister(dev);
|
|
|
|
kfree(dev);
|
|
}
|
|
|
|
#ifdef CONFIG_VIDEO_AU0828_V4L2
|
|
static void au0828_usb_v4l2_release(struct v4l2_device *v4l2_dev)
|
|
{
|
|
struct au0828_dev *dev =
|
|
container_of(v4l2_dev, struct au0828_dev, v4l2_dev);
|
|
|
|
v4l2_ctrl_handler_free(&dev->v4l2_ctrl_hdl);
|
|
v4l2_device_unregister(&dev->v4l2_dev);
|
|
au0828_usb_release(dev);
|
|
}
|
|
#endif
|
|
|
|
static void au0828_usb_disconnect(struct usb_interface *interface)
|
|
{
|
|
struct au0828_dev *dev = usb_get_intfdata(interface);
|
|
|
|
dprintk(1, "%s()\n", __func__);
|
|
|
|
/* there is a small window after disconnect, before
|
|
dev->usbdev is NULL, for poll (e.g: IR) try to access
|
|
the device and fill the dmesg with error messages.
|
|
Set the status so poll routines can check and avoid
|
|
access after disconnect.
|
|
*/
|
|
dev->dev_state = DEV_DISCONNECTED;
|
|
|
|
au0828_rc_unregister(dev);
|
|
/* Digital TV */
|
|
au0828_dvb_unregister(dev);
|
|
|
|
usb_set_intfdata(interface, NULL);
|
|
mutex_lock(&dev->mutex);
|
|
dev->usbdev = NULL;
|
|
mutex_unlock(&dev->mutex);
|
|
#ifdef CONFIG_VIDEO_AU0828_V4L2
|
|
if (AUVI_INPUT(0).type != AU0828_VMUX_UNDEFINED) {
|
|
au0828_analog_unregister(dev);
|
|
v4l2_device_disconnect(&dev->v4l2_dev);
|
|
v4l2_device_put(&dev->v4l2_dev);
|
|
return;
|
|
}
|
|
#endif
|
|
au0828_usb_release(dev);
|
|
}
|
|
|
|
static int au0828_usb_probe(struct usb_interface *interface,
|
|
const struct usb_device_id *id)
|
|
{
|
|
int ifnum;
|
|
int retval = 0;
|
|
|
|
struct au0828_dev *dev;
|
|
struct usb_device *usbdev = interface_to_usbdev(interface);
|
|
|
|
ifnum = interface->altsetting->desc.bInterfaceNumber;
|
|
|
|
if (ifnum != 0)
|
|
return -ENODEV;
|
|
|
|
dprintk(1, "%s() vendor id 0x%x device id 0x%x ifnum:%d\n", __func__,
|
|
le16_to_cpu(usbdev->descriptor.idVendor),
|
|
le16_to_cpu(usbdev->descriptor.idProduct),
|
|
ifnum);
|
|
|
|
/*
|
|
* Make sure we have 480 Mbps of bandwidth, otherwise things like
|
|
* video stream wouldn't likely work, since 12 Mbps is generally
|
|
* not enough even for most Digital TV streams.
|
|
*/
|
|
if (usbdev->speed != USB_SPEED_HIGH && disable_usb_speed_check == 0) {
|
|
pr_err("au0828: Device initialization failed.\n");
|
|
pr_err("au0828: Device must be connected to a high-speed USB 2.0 port.\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
|
|
if (dev == NULL) {
|
|
pr_err("%s() Unable to allocate memory\n", __func__);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
mutex_init(&dev->lock);
|
|
mutex_lock(&dev->lock);
|
|
mutex_init(&dev->mutex);
|
|
mutex_init(&dev->dvb.lock);
|
|
dev->usbdev = usbdev;
|
|
dev->boardnr = id->driver_info;
|
|
|
|
#ifdef CONFIG_VIDEO_AU0828_V4L2
|
|
dev->v4l2_dev.release = au0828_usb_v4l2_release;
|
|
|
|
/* Create the v4l2_device */
|
|
retval = v4l2_device_register(&interface->dev, &dev->v4l2_dev);
|
|
if (retval) {
|
|
pr_err("%s() v4l2_device_register failed\n",
|
|
__func__);
|
|
mutex_unlock(&dev->lock);
|
|
kfree(dev);
|
|
return retval;
|
|
}
|
|
/* This control handler will inherit the controls from au8522 */
|
|
retval = v4l2_ctrl_handler_init(&dev->v4l2_ctrl_hdl, 4);
|
|
if (retval) {
|
|
pr_err("%s() v4l2_ctrl_handler_init failed\n",
|
|
__func__);
|
|
mutex_unlock(&dev->lock);
|
|
kfree(dev);
|
|
return retval;
|
|
}
|
|
dev->v4l2_dev.ctrl_handler = &dev->v4l2_ctrl_hdl;
|
|
#endif
|
|
|
|
/* Power Up the bridge */
|
|
au0828_write(dev, REG_600, 1 << 4);
|
|
|
|
/* Bring up the GPIO's and supporting devices */
|
|
au0828_gpio_setup(dev);
|
|
|
|
/* I2C */
|
|
au0828_i2c_register(dev);
|
|
|
|
/* Setup */
|
|
au0828_card_setup(dev);
|
|
|
|
#ifdef CONFIG_VIDEO_AU0828_V4L2
|
|
/* Analog TV */
|
|
if (AUVI_INPUT(0).type != AU0828_VMUX_UNDEFINED)
|
|
au0828_analog_register(dev, interface);
|
|
#endif
|
|
|
|
/* Digital TV */
|
|
retval = au0828_dvb_register(dev);
|
|
if (retval)
|
|
pr_err("%s() au0282_dev_register failed\n",
|
|
__func__);
|
|
|
|
/* Remote controller */
|
|
au0828_rc_register(dev);
|
|
|
|
/*
|
|
* Store the pointer to the au0828_dev so it can be accessed in
|
|
* au0828_usb_disconnect
|
|
*/
|
|
usb_set_intfdata(interface, dev);
|
|
|
|
pr_info("Registered device AU0828 [%s]\n",
|
|
dev->board.name == NULL ? "Unset" : dev->board.name);
|
|
|
|
mutex_unlock(&dev->lock);
|
|
|
|
return retval;
|
|
}
|
|
|
|
static int au0828_suspend(struct usb_interface *interface,
|
|
pm_message_t message)
|
|
{
|
|
struct au0828_dev *dev = usb_get_intfdata(interface);
|
|
|
|
if (!dev)
|
|
return 0;
|
|
|
|
pr_info("Suspend\n");
|
|
|
|
au0828_rc_suspend(dev);
|
|
au0828_v4l2_suspend(dev);
|
|
au0828_dvb_suspend(dev);
|
|
|
|
/* FIXME: should suspend also ATV/DTV */
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int au0828_resume(struct usb_interface *interface)
|
|
{
|
|
struct au0828_dev *dev = usb_get_intfdata(interface);
|
|
if (!dev)
|
|
return 0;
|
|
|
|
pr_info("Resume\n");
|
|
|
|
/* Power Up the bridge */
|
|
au0828_write(dev, REG_600, 1 << 4);
|
|
|
|
/* Bring up the GPIO's and supporting devices */
|
|
au0828_gpio_setup(dev);
|
|
|
|
au0828_rc_resume(dev);
|
|
au0828_v4l2_resume(dev);
|
|
au0828_dvb_resume(dev);
|
|
|
|
/* FIXME: should resume also ATV/DTV */
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct usb_driver au0828_usb_driver = {
|
|
.name = KBUILD_MODNAME,
|
|
.probe = au0828_usb_probe,
|
|
.disconnect = au0828_usb_disconnect,
|
|
.id_table = au0828_usb_id_table,
|
|
.suspend = au0828_suspend,
|
|
.resume = au0828_resume,
|
|
.reset_resume = au0828_resume,
|
|
};
|
|
|
|
static int __init au0828_init(void)
|
|
{
|
|
int ret;
|
|
|
|
if (au0828_debug & 1)
|
|
pr_info("%s() Debugging is enabled\n", __func__);
|
|
|
|
if (au0828_debug & 2)
|
|
pr_info("%s() USB Debugging is enabled\n", __func__);
|
|
|
|
if (au0828_debug & 4)
|
|
pr_info("%s() I2C Debugging is enabled\n", __func__);
|
|
|
|
if (au0828_debug & 8)
|
|
pr_info("%s() Bridge Debugging is enabled\n",
|
|
__func__);
|
|
|
|
if (au0828_debug & 16)
|
|
pr_info("%s() IR Debugging is enabled\n",
|
|
__func__);
|
|
|
|
pr_info("au0828 driver loaded\n");
|
|
|
|
ret = usb_register(&au0828_usb_driver);
|
|
if (ret)
|
|
pr_err("usb_register failed, error = %d\n", ret);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void __exit au0828_exit(void)
|
|
{
|
|
usb_deregister(&au0828_usb_driver);
|
|
}
|
|
|
|
module_init(au0828_init);
|
|
module_exit(au0828_exit);
|
|
|
|
MODULE_DESCRIPTION("Driver for Auvitek AU0828 based products");
|
|
MODULE_AUTHOR("Steven Toth <stoth@linuxtv.org>");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_VERSION("0.0.3");
|