Jan Kara
90e775b71a
ext4: fix lost truncate due to race with writeback ...
The following race can lead to a loss of i_disksize update from truncate
thus resulting in a wrong inode size if the inode size isn't updated
again before inode is reclaimed:
ext4_setattr() mpage_map_and_submit_extent()
EXT4_I(inode)->i_disksize = attr->ia_size;
... ...
disksize = ((loff_t)mpd->first_page) << PAGE_CACHE_SHIFT
/* False because i_size isn't
* updated yet */
if (disksize > i_size_read(inode))
/* True, because i_disksize is
* already truncated */
if (disksize > EXT4_I(inode)->i_disksize)
/* Overwrite i_disksize
* update from truncate */
ext4_update_i_disksize()
i_size_write(inode, attr->ia_size);
For other places updating i_disksize such race cannot happen because
i_mutex prevents these races. Writeback is the only place where we do
not hold i_mutex and we cannot grab it there because of lock ordering.
We fix the race by doing both i_disksize and i_size update in truncate
atomically under i_data_sem and in mpage_map_and_submit_extent() we move
the check against i_size under i_data_sem as well.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2013-08-17 10:09:31 -04:00
2013-07-11 10:21:23 -07:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:57:36 +04:00
2013-07-03 09:10:19 -07:00
2013-07-05 18:59:33 +04:00
2013-06-29 12:56:55 +04:00
2013-06-29 12:56:33 +04:00
2013-07-19 15:07:26 -04:00
2013-07-03 16:07:31 -07:00
2013-07-09 12:39:10 -07:00
2013-07-11 18:05:41 -05:00
2013-07-05 18:59:33 +04:00
2013-07-14 11:42:26 -07:00
2013-06-29 12:56:46 +04:00
2013-06-03 13:55:02 -07:00
2013-03-07 01:08:55 -08:00
2013-06-26 11:38:02 -05:00
2013-07-11 10:20:18 -07:00
2013-07-14 17:48:35 +04:00
2013-06-29 12:56:31 +04:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:57:05 +04:00
2013-06-29 12:57:10 +04:00
2013-07-20 22:03:20 -04:00
2013-08-17 10:09:31 -04:00
2013-07-08 13:35:48 +04:00
2013-07-09 10:33:25 -07:00
2013-06-29 12:56:53 +04:00
2013-06-19 14:16:47 +01:00
2013-07-03 16:07:35 -07:00
2013-07-03 09:10:19 -07:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:57:36 +04:00
2013-06-29 12:56:59 +04:00
2013-07-04 11:22:55 -07:00
2013-07-03 16:07:41 -07:00
2013-05-07 18:38:27 -07:00
2013-06-29 12:57:36 +04:00
2013-05-21 23:26:36 -04:00
2013-07-01 08:12:41 -04:00
2013-06-29 12:56:47 +04:00
2013-07-11 10:19:34 -07:00
2013-07-17 13:43:55 -07:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:57:35 +04:00
2013-07-09 10:33:25 -07:00
2013-07-17 16:54:46 -04:00
2013-02-13 06:15:14 -08:00
2013-07-17 13:43:55 -07:00
2013-07-05 18:59:33 +04:00
2013-07-09 10:33:20 -07:00
2013-07-02 09:39:34 -07:00
2013-07-03 16:07:25 -07:00
2013-06-29 12:56:37 +04:00
2013-06-29 12:56:32 +04:00
2013-07-18 13:40:18 +02:00
2013-07-04 10:29:23 -07:00
2013-06-29 12:56:38 +04:00
2013-06-29 12:56:39 +04:00
2013-08-17 09:32:32 -04:00
2013-02-26 20:16:07 -08:00
2013-07-02 09:39:34 -07:00
2013-06-29 12:56:29 +04:00
2013-06-29 12:56:28 +04:00
2013-07-16 10:57:36 -07:00
2013-06-29 12:57:36 +04:00
2013-07-05 12:08:47 -07:00
2013-06-29 12:57:12 +04:00
2013-06-29 12:46:47 +04:00
2013-07-13 11:40:24 -07:00
2013-07-03 16:08:06 -07:00
2013-02-26 02:46:11 -05:00
2012-11-20 04:17:24 -08:00
2013-06-29 12:57:04 +04:00
2013-07-10 18:11:34 -07:00
2013-05-02 10:16:16 -07:00
2013-07-10 18:11:34 -07:00
2012-12-17 17:15:23 -08:00
2013-04-29 15:40:23 -04:00
2013-04-30 17:04:03 -07:00
2012-12-20 17:40:19 -08:00
2012-11-28 21:53:38 -05:00
2013-03-23 14:26:34 -07:00
2013-05-08 10:13:35 -07:00
2013-07-11 13:03:24 -07:00
2013-07-03 16:07:29 -07:00
2012-10-22 08:50:37 +03:00
2012-10-06 03:05:17 +09:00
2013-06-29 12:46:44 +04:00
2013-06-29 12:57:05 +04:00
2013-07-03 16:08:02 -07:00
2012-10-06 03:05:15 +09:00
2013-07-03 09:10:19 -07:00
2013-03-03 23:00:23 -05:00
2013-05-08 10:13:35 -07:00
2012-12-17 17:15:27 -08:00
2013-07-03 17:12:13 -07:00
2013-07-03 16:08:03 -07:00
2013-02-22 23:31:31 -05:00
2012-12-20 14:04:11 -08:00
2013-07-13 13:29:10 +04:00
2013-05-01 17:31:42 -04:00
2013-03-03 19:36:31 -08:00
2013-03-01 23:51:07 -05:00
2013-07-09 10:33:22 -07:00
2013-06-29 12:57:11 +04:00
2013-06-29 12:57:34 +04:00
2013-02-22 23:31:31 -05:00
2013-04-17 13:25:09 +01:00
2013-04-30 17:04:04 -07:00
2013-07-14 17:43:25 +04:00
2013-07-08 13:36:42 +04:00
2013-05-01 17:51:54 -07:00
2013-04-09 14:12:52 -04:00
2013-07-13 13:26:37 +04:00
2013-05-04 15:18:53 -04:00
2013-07-20 03:11:32 +04:00
2013-05-07 20:16:25 -07:00
2013-05-31 15:16:33 -04:00
2013-05-01 17:51:54 -07:00
2013-07-03 16:23:27 +04:00
2013-06-29 12:57:05 +04:00
2013-07-10 17:08:27 -07:00
2013-07-08 13:36:41 +04:00
2013-03-03 22:58:46 -05:00
2013-07-03 09:10:19 -07:00
2013-08-17 09:32:32 -04:00
2012-12-20 18:50:07 -05:00
2013-07-20 04:58:58 +04:00
2013-03-03 22:46:22 -05:00
2013-05-29 12:57:34 -07:00
2012-12-20 18:50:08 -05:00
2012-10-12 13:16:48 -07:00
2012-12-20 18:50:11 -05:00
90e775b71a