Pavel Begunkov
97a73a0f9f
io_uring: fix io_sq_offload_create error handling
...
Don't set IO_SQ_THREAD_SHOULD_STOP when io_sq_offload_create() has
failed on io_uring_alloc_task_context() but leave everything to
io_sq_thread_finish(), because currently io_sq_thread_finish()
hangs on trying to park it. That's great it stalls there, because
otherwise the following io_sq_thread_stop() would be skipped on
IO_SQ_THREAD_SHOULD_STOP check and the sqo would race for sqd with
freeing ctx.
A simple error injection gives something like this.
[ 245.463955] INFO: task sqpoll-test-hang:523 blocked for more than 122 seconds.
[ 245.463983] Call Trace:
[ 245.463990] __schedule+0x36b/0x950
[ 245.464005] schedule+0x68/0xe0
[ 245.464013] schedule_timeout+0x209/0x2a0
[ 245.464032] wait_for_completion+0x8b/0xf0
[ 245.464043] io_sq_thread_finish+0x44/0x1a0
[ 245.464049] io_uring_setup+0x9ea/0xc80
[ 245.464058] __x64_sys_io_uring_setup+0x16/0x20
[ 245.464064] do_syscall_64+0x38/0x50
[ 245.464073] entry_SYSCALL_64_after_hwframe+0x44/0xae
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2021-03-10 07:28:42 -07:00
..
2021-02-27 08:07:12 -08:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2020-09-18 16:45:50 -04:00
2021-01-24 14:27:20 +01:00
2021-03-05 12:21:14 -08:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-02-26 14:09:41 -08:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:27:20 +01:00
2021-01-05 23:02:47 -05:00
2021-01-24 14:27:16 +01:00
2021-02-24 10:13:55 -08:00
2020-11-10 12:14:20 -06:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2020-09-18 16:45:50 -04:00
2021-02-28 11:23:38 -08:00
2021-02-23 13:39:45 -08:00
2020-12-09 09:39:38 -05:00
2021-01-24 14:27:20 +01:00
2021-02-28 11:23:38 -08:00
2021-02-28 11:23:38 -08:00
2021-02-23 13:39:45 -08:00
2020-06-03 16:27:18 -07:00
2021-02-24 13:38:27 -08:00
2021-02-27 08:07:12 -08:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2021-02-24 13:38:35 -08:00
2021-02-28 11:45:25 -08:00
2021-02-03 19:05:52 +01:00
2021-01-27 09:51:48 -07:00
2021-02-23 13:39:45 -08:00
2021-02-27 08:07:12 -08:00
2021-02-23 13:39:45 -08:00
2021-01-25 09:36:23 -05:00
2021-01-24 14:27:20 +01:00
2021-02-28 11:23:38 -08:00
2021-01-28 10:55:37 -05:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2020-06-14 01:57:21 +09:00
2021-02-23 13:39:45 -08:00
2021-02-24 13:38:26 -08:00
2021-02-24 13:38:26 -08:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-02-27 08:29:02 -08:00
2021-03-05 17:21:25 -08:00
2020-09-18 16:45:50 -04:00
2020-09-18 16:45:50 -04:00
2021-01-05 14:42:18 +01:00
2021-02-24 13:38:26 -08:00
2021-02-23 13:39:45 -08:00
2020-10-24 12:26:05 -07:00
2021-02-09 17:26:44 -08:00
2021-01-12 14:26:31 +01:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2020-09-10 14:03:31 -07:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-28 11:45:25 -08:00
2021-02-23 13:39:45 -08:00
2020-12-15 12:53:37 -08:00
2021-01-15 12:17:25 -05:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:27:20 +01:00
2020-05-07 16:55:47 -05:00
2021-02-21 13:20:41 -08:00
2021-02-21 13:20:41 -08:00
2020-06-04 19:18:29 -07:00
2020-08-24 08:49:13 +10:00
2021-02-15 18:28:30 +01:00
2020-06-04 19:18:29 -07:00
2021-02-28 11:23:38 -08:00
2021-02-24 13:38:30 -08:00
2020-05-14 16:44:23 +02:00
2021-01-06 08:42:51 -05:00
2021-02-26 09:41:05 -08:00
2020-10-14 14:54:45 -07:00
2021-02-09 07:05:44 -05:00
2021-02-24 13:38:26 -08:00
2021-02-28 11:23:38 -08:00
2020-11-15 09:49:10 -05:00
2021-02-16 09:59:41 +01:00
2021-02-24 13:38:26 -08:00
2021-02-23 13:39:45 -08:00
2021-02-24 13:38:26 -08:00
2020-10-25 20:02:08 -04:00
2021-02-01 10:02:42 -07:00
2020-08-23 17:36:59 -05:00
2020-10-13 18:38:27 -07:00
2020-07-29 16:14:27 +02:00
2021-01-13 17:26:50 +01:00
2020-08-23 17:36:59 -05:00
2021-01-24 14:27:19 +01:00
2021-02-27 08:07:12 -08:00
2021-02-23 13:39:45 -08:00
2021-03-10 07:28:42 -07:00
2021-03-10 07:28:42 -07:00
2021-03-06 10:57:01 -07:00
2020-07-31 08:16:01 +02:00
2021-02-21 10:22:20 -08:00
2021-02-21 09:29:23 -08:00
2020-10-05 13:37:04 +02:00
2021-02-23 13:39:45 -08:00
2020-12-15 19:29:43 -08:00
2021-01-29 10:06:46 +05:30
2021-01-24 14:29:34 +01:00
2021-02-26 15:49:51 -07:00
2021-02-23 13:39:45 -08:00
2021-02-27 08:07:12 -08:00
2020-05-13 11:41:22 +02:00
2021-02-23 13:39:45 -08:00
2021-02-24 13:38:26 -08:00
2020-12-10 17:33:17 -05:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:43:45 +01:00
2021-01-25 23:29:36 -05:00
2020-07-31 08:16:00 +02:00
2021-01-24 14:27:19 +01:00
2021-01-08 11:06:29 -08:00
2021-01-21 14:06:00 -07:00
2020-08-23 17:36:59 -05:00
2021-02-21 11:02:48 -08:00
2021-01-24 14:27:20 +01:00
2021-02-13 17:17:53 +01:00
2021-02-22 10:57:46 -08:00
2020-06-09 15:40:50 -07:00
2021-01-14 17:40:57 -05:00
2021-01-24 14:27:18 +01:00
2021-01-24 14:27:17 +01:00