Marc Zyngier
a0db197f53
gpiolib: cdev: Flag invalid GPIOs as used ...
When reporting the state of a GPIO to userspace, we never check
for the actual validity of the line, meaning we report invalid
lines as being usable. A subsequent request will fail though,
which is an inconsistent behaviour from a userspace perspective.
Instead, let's check for the validity of the line and report it
as used if it is invalid. This allows a tool such as gpioinfo
to report something sensible:
gpiochip3 - 4 lines:
line 0: unnamed unused input active-high
line 1: unnamed kernel input active-high [used]
line 2: unnamed kernel input active-high [used]
line 3: unnamed unused input active-high
In this example, lines 1 and 2 are invalid, and cannot be used by
userspace.
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20201204164739.781812-2-maz@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2020-12-09 10:23:04 +01:00
2019-12-04 19:44:12 -08:00
2019-11-07 09:27:48 +01:00
2020-07-23 15:09:26 +02:00
2020-10-29 14:58:00 +01:00
2020-07-23 15:10:25 +02:00
2020-07-20 15:34:59 +02:00
2019-05-30 11:25:18 -07:00
2020-07-20 15:47:50 +02:00
2020-08-18 21:39:39 +02:00
2019-05-30 11:29:52 -07:00
2020-07-08 09:24:07 +02:00
2020-12-08 09:41:32 +01:00
2020-09-28 12:22:04 +02:00
2019-07-09 09:07:00 -07:00
2020-06-16 10:38:07 +02:00
2020-10-02 09:51:42 -07:00
2020-10-26 15:51:57 +01:00
2020-08-23 17:36:59 -05:00
2020-08-28 20:13:51 +02:00
2019-11-07 09:27:48 +01:00
2019-12-01 17:56:50 -08:00
2020-02-10 10:55:18 +01:00
2020-03-26 00:02:03 +01:00
2020-12-08 09:41:32 +01:00
2019-08-15 09:44:19 +02:00
2019-05-30 11:26:32 -07:00
2020-01-23 16:16:05 +01:00
2020-08-04 01:25:02 +02:00
2019-07-15 11:03:02 -03:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-08-28 20:15:06 +02:00
2020-07-23 15:03:25 +02:00
2020-10-26 15:48:25 +01:00
2020-08-23 17:36:59 -05:00
2019-11-13 13:47:48 +01:00
2019-09-04 10:59:10 +02:00
2020-05-05 18:24:56 +02:00
2020-05-05 18:22:26 +02:00
2020-04-28 15:50:28 +02:00
2018-05-16 14:35:24 +02:00
2019-12-04 19:44:12 -08:00
2020-01-15 11:24:19 +01:00
2019-02-09 11:33:37 +01:00
2019-08-15 09:57:29 +02:00
2019-11-07 09:27:48 +01:00
2020-07-22 16:00:27 +03:00
2019-10-15 01:18:51 +02:00
2019-07-15 21:10:39 -07:00
2020-07-08 09:24:08 +02:00
2019-09-03 16:04:19 +02:00
2019-07-09 09:07:00 -07:00
2019-11-07 09:27:48 +01:00
2019-12-13 09:50:29 +01:00
2019-04-05 00:04:26 +07:00
2019-10-31 15:03:10 -07:00
2019-11-07 09:27:48 +01:00
2019-06-05 17:37:10 +02:00
2019-11-07 09:27:48 +01:00
2019-04-05 00:04:26 +07:00
2019-08-15 21:33:07 +02:00
2019-11-07 09:27:48 +01:00
2020-05-22 17:01:25 +02:00
2020-08-04 01:12:43 +02:00
2019-12-04 19:44:13 -08:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-07-17 14:03:38 +02:00
2019-07-29 00:03:52 +02:00
2020-05-18 09:15:16 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:29:19 -07:00
2019-11-03 19:54:53 +01:00
2020-04-16 20:41:06 +03:00
2020-06-30 17:00:11 +03:00
2020-07-08 09:24:08 +02:00
2020-07-08 09:24:08 +02:00
2020-04-28 22:41:25 +02:00
2020-07-16 15:07:18 +02:00
2020-09-30 10:52:21 +02:00
2019-11-07 09:27:48 +01:00
2020-09-30 10:50:30 +02:00
2019-06-05 17:37:06 +02:00
2020-12-05 22:41:22 +01:00
2019-02-08 15:55:41 +02:00
2020-03-25 09:50:45 +01:00
2020-06-20 23:13:27 +02:00
2020-11-18 08:52:22 +01:00
2020-12-04 09:08:54 +01:00
2019-04-05 00:04:27 +07:00
2020-10-28 16:40:47 +01:00
2019-05-30 11:29:52 -07:00
2020-10-13 10:09:33 -07:00
2020-07-16 14:35:12 +02:00
2020-07-20 15:56:40 +02:00
2020-07-21 19:12:57 +03:00
2020-07-23 15:11:26 +02:00
2020-11-06 15:19:44 +01:00
2020-08-28 20:15:51 +02:00
2020-04-14 16:23:46 +02:00
2020-07-08 09:24:07 +02:00
2020-05-25 11:14:36 +02:00
2019-11-07 09:27:48 +01:00
2019-05-30 11:29:52 -07:00
2020-07-30 00:13:10 +02:00
2019-10-29 15:12:52 +01:00
2019-05-24 17:36:45 +02:00
2019-11-07 09:27:48 +01:00
2020-06-03 10:48:37 +02:00
2019-11-07 09:27:48 +01:00
2020-07-08 09:24:07 +02:00
2019-11-07 09:27:48 +01:00
2020-07-22 16:00:27 +03:00
2020-12-04 09:05:12 +01:00
2020-09-09 12:59:15 +02:00
2020-09-17 16:00:20 +01:00
2018-12-07 17:34:08 +02:00
2019-04-05 00:04:27 +07:00
2020-08-31 18:06:28 +02:00
2019-06-05 17:37:06 +02:00
2020-10-28 15:51:27 +01:00
2020-08-18 21:32:28 +02:00
2020-07-08 09:24:08 +02:00
2019-12-12 17:09:50 +01:00
2020-10-13 10:09:33 -07:00
2020-12-04 09:05:12 +01:00
2020-04-28 16:22:33 +02:00
2020-01-15 11:18:29 +01:00
2019-05-30 11:29:19 -07:00
2019-11-07 09:27:48 +01:00
2018-09-04 08:22:47 +02:00
2019-11-07 09:27:48 +01:00
2019-05-24 17:39:01 +02:00
2018-09-04 08:22:47 +02:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2019-04-05 00:04:28 +07:00
2019-11-07 09:27:48 +01:00
2018-09-04 08:22:47 +02:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2019-06-19 17:09:55 +02:00
2020-03-02 08:52:55 +01:00
2019-08-23 09:41:18 +02:00
2019-08-05 11:26:58 +02:00
2019-06-27 15:56:51 +01:00
2020-01-15 13:45:01 +01:00
2020-02-10 10:50:58 +01:00
2020-08-04 01:25:02 +02:00
2018-01-09 14:51:00 +01:00
2018-09-17 10:55:24 -07:00
2018-09-17 10:55:24 -07:00
2018-09-17 10:55:24 -07:00
2020-07-23 15:08:55 +02:00
2020-05-18 09:16:31 +02:00
2019-11-07 09:27:48 +01:00
2020-01-29 09:51:36 -08:00
2020-11-18 08:52:22 +01:00
2019-08-15 09:55:07 +02:00
2020-06-20 23:13:27 +02:00
2019-12-09 10:40:18 +01:00
2019-06-19 17:09:55 +02:00
2020-04-02 09:16:06 +02:00
2020-08-28 20:16:06 +02:00
2020-11-16 14:14:35 +02:00
2020-11-16 14:14:35 +02:00
2020-12-09 10:23:04 +01:00
2020-11-05 15:35:40 +01:00
2020-08-04 01:22:02 +02:00
2018-09-25 09:08:48 +02:00
2020-09-14 10:54:01 +02:00
2020-02-21 17:10:33 +01:00
2020-07-12 10:22:00 +02:00
2020-07-12 10:22:00 +02:00
2020-12-05 23:27:01 +01:00
2020-12-05 23:22:47 +01:00
2020-12-05 22:41:22 +01:00
2020-12-05 22:41:22 +01:00
2020-12-06 00:13:17 +01:00
a0db197f53