Kernel/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-01-10 15:19:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
linux/fs/ceph
History
Jeff Layton a81bc3102b ceph: take the inode lock before acquiring cap refs 
Most of the time, we (or the vfs layer) takes the inode_lock and then
acquires caps, but ceph_read_iter does the opposite, and that can lead
to a deadlock.

When there are multiple clients treading over the same data, we can end
up in a situation where a reader takes caps and then tries to acquire
the inode_lock. Another task holds the inode_lock and issues a request
to the MDS which needs to revoke the caps, but that can't happen until
the inode_lock is unwedged.

Fix this by having ceph_read_iter take the inode_lock earlier, before
attempting to acquire caps.

Fixes: 321fe13c9398 ("ceph: add buffered/direct exclusionary locking for reads and writes")
Link: https://tracker.ceph.com/issues/36348
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2019-11-14 18:44:51 +01:00
..
acl.c
ceph: rename struct ceph_acls_info to ceph_acl_sec_ctx
2019-07-08 14:01:42 +02:00
addr.c
ceph: use release_pages() directly
2019-09-16 12:06:25 +02:00
cache.c
ceph: include ceph_debug.h in cache.c
2019-09-16 12:06:25 +02:00
cache.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 188
2019-05-30 11:29:21 -07:00
caps.c
ceph: fix use-after-free in __ceph_remove_cap()
2019-10-29 22:29:51 +01:00
ceph_frag.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debugfs.c
ceph: don't return a value from void function
2019-09-16 12:06:25 +02:00
dir.c
ceph: fix RCU case handling in ceph_d_revalidate()
2019-10-29 22:29:54 +01:00
export.c
ceph: move static keyword to the front of declarations
2019-09-16 12:06:25 +02:00
file.c
ceph: take the inode lock before acquiring cap refs
2019-11-14 18:44:51 +01:00
inode.c
ceph: add missing check in d_revalidate snapdir handling
2019-10-29 22:29:55 +01:00
io.c
ceph: add buffered/direct exclusionary locking for reads and writes
2019-09-16 12:06:25 +02:00
io.h
ceph: add buffered/direct exclusionary locking for reads and writes
2019-09-16 12:06:25 +02:00
ioctl.c
libceph, ceph: move ceph_calc_file_object_mapping() to striper.c
2018-04-02 10:12:43 +02:00
ioctl.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
Kconfig
ceph: add selinux support
2019-07-08 14:01:42 +02:00
locks.c
ceph: return -EIO if read/write against filp that lost file locks
2019-09-16 12:06:24 +02:00
Makefile
ceph: add buffered/direct exclusionary locking for reads and writes
2019-09-16 12:06:25 +02:00
mds_client.c
ceph: just skip unrecognized info in ceph_reply_info_extra
2019-10-15 17:43:10 +02:00
mds_client.h
ceph: eliminate session->s_trim_caps
2019-09-16 12:06:24 +02:00
mdsmap.c
ceph: have MDS map decoding use entity_addr_t decoder
2019-07-08 14:01:43 +02:00
quota.c
ceph: fix infinite loop in get_quota_realm()
2019-07-08 14:01:42 +02:00
snap.c
ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob()
2019-08-22 10:47:41 +02:00
strings.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
super.c
ceph: return -EINVAL if given fsc mount option on kernel w/o support
2019-11-07 18:03:23 +01:00
super.h
ceph: turn ceph_security_invalidate_secctx into static inline
2019-09-16 12:06:25 +02:00
xattr.c
ceph: allow arbitrary security.* xattrs
2019-09-16 12:06:25 +02:00