linux/fs/xfs/linux-2.6
Alex Elder af24ee9ea8 xfs: zero proper structure size for geometry calls
Commit 493f3358cb289ccf716c5a14fa5bb52ab75943e5 added this call to
xfs_fs_geometry() in order to avoid passing kernel stack data back
to user space:

+       memset(geo, 0, sizeof(*geo));

Unfortunately, one of the callers of that function passes the
address of a smaller data type, cast to fit the type that
xfs_fs_geometry() requires.  As a result, this can happen:

Kernel panic - not syncing: stack-protector: Kernel stack is corrupted
in: f87aca93

Pid: 262, comm: xfs_fsr Not tainted 2.6.38-rc6-493f3358cb2+ #1
Call Trace:

[<c12991ac>] ? panic+0x50/0x150
[<c102ed71>] ? __stack_chk_fail+0x10/0x18
[<f87aca93>] ? xfs_ioc_fsgeometry_v1+0x56/0x5d [xfs]

Fix this by fixing that one caller to pass the right type and then
copy out the subset it is interested in.

Note: This patch is an alternative to one originally proposed by
Eric Sandeen.

Reported-by: Jeffrey Hundstad <jeffrey.hundstad@mnsu.edu>
Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Tested-by: Jeffrey Hundstad <jeffrey.hundstad@mnsu.edu>
2011-03-01 21:21:13 -06:00
..
2008-04-29 15:54:02 +10:00
2010-12-16 16:06:07 -06:00
2010-12-16 16:05:51 -06:00
2011-01-11 20:28:29 -06:00
2007-10-22 08:13:20 -07:00
2010-10-18 15:08:06 -05:00
2009-09-15 12:29:24 -05:00
2008-10-30 16:55:03 +11:00
2010-10-18 15:08:04 -05:00
2011-01-11 20:28:29 -06:00
2009-12-14 23:08:16 -06:00
2010-05-21 18:31:19 -04:00