Bo Chen cf1acec008 e1000: check on netif_running() before calling e1000_up() ...

When the device is not up, the call to 'e1000_up()' from the error handling path
of 'e1000_set_ringparam()' causes a kernel oops with a null-pointer
dereference. The null-pointer dereference is triggered in function
'e1000_alloc_rx_buffers()' at line 'buffer_info = &rx_ring->buffer_info[i]'.

This bug was reported by COD, a tool for testing kernel module binaries I am
building. This bug was also detected by KFI from Dr. Kai Cong.

This patch fixes the bug by checking on 'netif_running()' before calling
'e1000_up()' in 'e1000_set_ringparam()'.

Signed-off-by: Bo Chen <chenbo@pdx.edu>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

2018-08-24 08:52:35 -07:00

..

appletalk

…

arcnet

…

bonding

Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net

2018-08-02 10:55:32 -07:00

caif

…

can

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2018-08-15 15:04:25 -07:00

dsa

net: dsa: add support for ksz9897 ethernet switch

2018-08-16 12:24:55 -07:00

ethernet

e1000: check on netif_running() before calling e1000_up()

2018-08-24 08:52:35 -07:00

fddi

…

fjes

fjes: use currently unused variable my_epid and max_epid

2018-07-05 19:34:21 +09:00

hamradio

net/hamradio/6pack: remove redundant variable channel

2018-07-05 19:34:45 +09:00

hippi

treewide: kmalloc() -> kmalloc_array()

2018-06-12 16:19:22 -07:00

hyperv

hv_netvsc: ignore devices that are not PCI

2018-08-21 12:02:11 -07:00

ieee802154

ieee802154: hwsim: using right kind of iteration

2018-08-14 09:58:57 -07:00

ipvlan

ipvlan: call dev_change_flags when ipvlan mode is reset

2018-07-02 20:38:09 +09:00

netdevsim

Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net

2018-08-02 10:55:32 -07:00

phy

net: dp83640: Mark expected switch fall-throughs

2018-08-11 11:28:34 -07:00

plip

…

ppp

ppp: mppe: Remove VLA usage

2018-08-03 12:54:54 -07:00

slip

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

team

team: Publish team_port_get_rcu()

2018-07-11 23:10:19 -07:00

usb

r8152: disable RX aggregation on new Dell TB16 dock

2018-08-20 13:03:29 -07:00

vmxnet3

…

wan

Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net

2018-08-05 13:04:31 -07:00

wimax

wimax: usb-tx: mark expected switch fall-through

2018-08-11 11:29:36 -07:00

wireless

Char/Misc driver patches for 4.19-rc1

2018-08-18 11:04:51 -07:00

xen-netback

xen-netback: use true and false for boolean values

2018-08-02 14:43:04 -07:00

dummy.c

…

eql.c

…

geneve.c

Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net

2018-07-03 10:29:26 +09:00

gtp.c

gtp: constify nla_policy

2018-07-20 12:33:37 -07:00

ifb.c

…

Kconfig

…

LICENSE.SRC

…

loopback.c

…

macsec.c

…

macvlan.c

macvlan: Change status when lower device goes down

2018-07-11 23:07:22 -07:00

macvtap.c

…

Makefile

…

mdio.c

…

mii.c

…

net_failover.c

failover: change mtu has RTNL

2018-07-29 12:57:26 -07:00

netconsole.c

…

nlmon.c

…

ntb_netdev.c

net: drivers/net: Convert random_ether_addr to eth_random_addr

2018-06-23 10:49:14 +09:00

rionet.c

…

sb1000.c

…

Space.c

…

sungem_phy.c

…

tap.c

…

thunderbolt.c

…

tun.c

tun: not use hardcoded mask value

2018-08-04 13:15:11 -07:00

veth.c

veth: Free queues on link delete

2018-08-16 12:22:31 -07:00

virtio_net.c

virtio_net: remove duplicated include from virtio_net.c

2018-08-13 09:21:05 -07:00

vrf.c

…

vsockmon.c

…

vxlan.c

vxlan: fix default fdb entry netlink notify ordering during netdev create

2018-07-22 10:52:37 -07:00

xen-netfront.c

xen-netfront: fix warn message as irq device name has '/'

2018-08-14 10:10:35 -07:00