mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-01-01 02:33:57 +00:00
f1ee5483e4
In the function yas537_measure() there is a clamp_val() with limits of
-BIT(13) and BIT(13) - 1. The input clamp value h[] is of type s32. The
BIT() is of type unsigned long integer due to its define in
include/vdso/bits.h. The lower limit -BIT(13) is recognized as -8192 but
expressed as an unsigned long integer. The size of an unsigned long
integer differs between 32-bit and 64-bit architectures. Converting this
to type s32 may lead to undesired behavior.
Additionally, in the calculation lines h[0], h[1] and h[2] the unsigned
long integer divisor BIT(13) causes an unsigned division, shifting the
left-hand side of the equation back and forth, possibly ending up in large
positive values instead of negative values on 32-bit architectures.
To solve those two issues, declare a signed integer with a value of
BIT(13).
There is another omission in the clamp line: clamp_val() returns a value
and it's going nowhere here. Self-assign it to h[i] to make use of the
clamp macro.
Finally, replace clamp_val() macro by clamp() because after changing the
limits from type unsigned long integer to signed integer it's fine that
way.
Link: https://lkml.kernel.org/r/11609b2243c295d65ab4d47e78c239d61ad6be75.1732914810.git.jahau@rocketmail.com
Fixes:
|
||
|---|---|---|
| .. | ||
| af8133j.c | ||
| ak8974.c | ||
| ak8975.c | ||
| als31300.c | ||
| bmc150_magn_i2c.c | ||
| bmc150_magn_spi.c | ||
| bmc150_magn.c | ||
| bmc150_magn.h | ||
| hid-sensor-magn-3d.c | ||
| hmc5843_core.c | ||
| hmc5843_i2c.c | ||
| hmc5843_spi.c | ||
| hmc5843.h | ||
| Kconfig | ||
| mag3110.c | ||
| Makefile | ||
| mmc35240.c | ||
| rm3100-core.c | ||
| rm3100-i2c.c | ||
| rm3100-spi.c | ||
| rm3100.h | ||
| st_magn_buffer.c | ||
| st_magn_core.c | ||
| st_magn_i2c.c | ||
| st_magn_spi.c | ||
| st_magn.h | ||
| tmag5273.c | ||
| yamaha-yas530.c | ||