Arnd Bergmann
3fc202e81d
HID: asus: fix build warning wiht CONFIG_ASUS_WMI disabled ...
asus_wmi_evaluate_method() is an empty dummy function when CONFIG_ASUS_WMI
is disabled, or not reachable from a built-in device driver. This leads to
a theoretical evaluation of an uninitialized variable that the compiler
complains about, failing to check that the hardcoded return value makes
this an unreachable code path:
In file included from include/linux/printk.h:336,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/dmi.h:5,
from drivers/hid/hid-asus.c:29:
drivers/hid/hid-asus.c: In function 'asus_input_configured':
include/linux/dynamic_debug.h:135:3: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~~~~~~~~~~~~~~~
drivers/hid/hid-asus.c:359:6: note: 'value' was declared here
u32 value;
^~~~~
With an extra IS_ENABLED() check, the warning goes away.
Fixes: 3b692c55e58d ("HID: asus: only support backlight when it's not driven by WMI")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2018-11-06 13:57:42 +01:00
2018-11-06 13:57:02 +01:00
2018-10-23 13:34:28 +02:00
2018-10-26 17:06:24 +02:00
2013-07-31 10:12:28 +02:00
2017-03-21 15:03:55 +01:00
2018-10-26 17:27:13 +02:00
2018-08-28 13:52:50 +02:00
2017-11-21 15:57:07 -08:00
2018-11-06 13:57:42 +01:00
2015-10-21 13:15:53 +02:00
2013-11-12 19:06:23 +01:00
2013-01-03 10:27:31 +01:00
2014-12-22 15:00:25 +01:00
2018-09-24 11:49:32 +02:00
2014-08-21 10:43:28 -05:00
2017-06-08 13:47:52 +02:00
2016-03-02 10:31:36 +01:00
2018-10-23 13:17:27 +02:00
2018-02-16 13:38:16 +01:00
2018-09-05 10:25:37 +02:00
2017-11-21 21:39:45 +01:00
2017-01-06 16:06:43 +01:00
2018-07-09 17:16:11 -07:00
2016-10-10 10:52:01 +02:00
2018-10-09 13:32:06 +02:00
2018-03-06 15:15:47 +01:00
2017-11-24 14:40:23 +01:00
2013-02-25 13:26:41 +01:00
2013-01-03 10:27:31 +01:00
2013-02-25 13:26:41 +01:00
2015-08-18 15:03:43 +02:00
2018-04-26 14:17:31 +02:00
2018-04-26 14:17:31 +02:00
2018-10-09 10:43:39 +02:00
2015-12-28 13:41:44 +01:00
2013-01-03 10:27:31 +01:00
2013-01-03 10:27:31 +01:00
2014-09-08 09:48:56 +02:00
2017-12-01 09:31:36 +01:00
2018-07-03 13:02:28 +02:00
2013-04-24 16:32:27 +02:00
2018-10-26 17:09:22 +02:00
2018-10-29 11:25:24 -07:00
2017-05-11 10:27:48 +02:00
2017-11-21 12:54:58 +01:00
2013-01-03 10:27:31 +01:00
2013-01-03 10:27:31 +01:00
2017-02-27 18:43:47 -08:00
2013-01-03 10:27:31 +01:00
2016-10-10 10:47:03 +02:00
2018-04-25 10:48:35 +02:00
2013-10-09 12:06:02 +02:00
2013-09-13 15:12:39 +02:00
2017-10-19 13:52:38 +02:00
2017-11-02 11:10:55 +01:00
2017-09-06 10:58:54 +02:00
2017-11-02 11:10:55 +01:00
2013-09-13 15:12:39 +02:00
2017-04-06 14:36:36 +02:00
2018-09-24 11:30:52 +02:00
2018-10-03 10:57:58 +02:00
2017-01-11 22:12:44 +01:00
2018-09-05 10:19:43 +02:00
2014-08-21 10:43:28 -05:00
2018-09-04 22:32:59 +02:00
2017-03-06 13:16:33 +01:00
2018-06-25 15:16:11 +02:00
2017-07-24 17:38:21 +02:00
2016-03-10 17:17:26 +01:00
2014-08-21 10:43:28 -05:00
2015-06-29 14:51:12 +02:00
2018-10-04 14:22:27 -04:00
2014-08-27 23:27:10 +02:00
2017-03-24 15:45:04 +01:00
2018-06-12 16:19:22 -07:00
2015-06-29 14:51:12 +02:00
2015-12-28 13:41:44 +01:00
2013-04-30 10:19:07 +02:00
2013-09-04 11:58:32 +02:00
2018-05-16 11:06:40 +02:00
2013-01-03 10:27:31 +01:00
2017-11-21 15:57:07 -08:00
2018-10-26 17:10:48 +02:00
2018-06-25 15:23:40 +02:00
2017-06-22 14:44:11 +02:00
2018-05-30 08:55:33 +02:00
2015-12-28 13:41:51 +01:00
2015-12-28 13:41:51 +01:00
2013-10-30 14:17:31 +01:00
2015-12-28 13:41:51 +01:00
2013-03-14 11:50:49 +01:00
2015-12-28 13:41:51 +01:00
2013-04-08 10:33:13 +02:00
2015-12-28 13:41:51 +01:00
2012-11-18 22:58:28 +01:00
2013-10-30 14:17:31 +01:00
2018-01-23 15:46:58 +01:00
2012-11-12 15:30:29 +01:00
2015-12-28 13:41:51 +01:00
2012-10-17 10:44:47 +02:00
2015-12-28 13:41:51 +01:00
2012-11-12 15:30:28 +01:00
2013-10-30 14:17:31 +01:00
2013-10-30 14:17:31 +01:00
2013-10-30 14:17:31 +01:00
2018-02-11 14:34:03 -08:00
2018-08-30 10:58:44 +02:00
2013-01-03 10:27:31 +01:00
2018-02-11 14:34:03 -08:00
2018-09-05 10:22:28 +02:00
2015-05-07 10:47:53 +02:00
2018-07-09 15:14:08 +02:00
2013-08-26 13:51:10 +02:00
2018-06-20 09:27:23 +02:00
2015-12-28 13:41:44 +01:00
2014-08-21 10:43:28 -05:00
2015-03-15 10:04:27 -04:00
2017-11-07 10:04:46 +01:00
2013-01-03 10:27:31 +01:00
2013-01-03 10:27:31 +01:00
2018-03-23 15:44:57 +01:00
2016-11-15 14:23:17 +01:00
2016-09-19 14:32:21 +02:00
2018-06-25 15:26:06 +02:00
2013-06-03 11:07:06 +02:00
2018-06-25 15:26:06 +02:00
2018-06-25 15:26:06 +02:00
2017-03-24 15:43:03 +01:00
2013-09-13 15:11:34 +02:00
2013-07-31 10:12:28 +02:00
2018-06-12 16:19:22 -07:00
2018-11-01 08:42:21 -07:00
2018-09-24 11:49:32 +02:00
2018-04-05 11:53:34 -07:00
2018-08-20 18:12:42 +02:00
2018-10-11 14:32:01 +02:00
2018-03-07 15:21:44 +01:00
2017-05-05 21:46:10 +02:00
3fc202e81d