From 217fa3961a5915a12e4ef6982e593e5215f8499c Mon Sep 17 00:00:00 2001 From: Zhang Zekun Date: Sat, 7 Sep 2024 16:07:01 +0800 Subject: [PATCH 1/2] OPP: Remove unused declarations in header file The definition of _update_set_required_opps() has been removed since commit e37440e7e2c2 ("OPP: Call dev_pm_opp_set_opp() for required OPPs"). Besides, the definition of _put_opp_list_kref() has been removed since commit 03758d60265c ("opp: Replace list_kref with a local counter"). Let's remove the empty declarations in header file. Signed-off-by: Zhang Zekun Signed-off-by: Viresh Kumar --- drivers/opp/opp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/opp/opp.h b/drivers/opp/opp.h index cff1fabd1ae3..882e32f121d3 100644 --- a/drivers/opp/opp.h +++ b/drivers/opp/opp.h @@ -262,9 +262,7 @@ int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, struct opp_table *o int _opp_add_v1(struct opp_table *opp_table, struct device *dev, struct dev_pm_opp_data *data, bool dynamic); void _dev_pm_opp_cpumask_remove_table(const struct cpumask *cpumask, int last_cpu); struct opp_table *_add_opp_table_indexed(struct device *dev, int index, bool getclk); -void _put_opp_list_kref(struct opp_table *opp_table); void _required_opps_available(struct dev_pm_opp *opp, int count); -void _update_set_required_opps(struct opp_table *opp_table); static inline bool lazy_linking_pending(struct opp_table *opp_table) { From 53205a7903666d35709954d9fb7370a8150d5e0e Mon Sep 17 00:00:00 2001 From: Dhruva Gole Date: Thu, 19 Sep 2024 18:43:40 +0530 Subject: [PATCH 2/2] dt-bindings: opp: operating-points-v2-ti-cpu: Describe opp-supported-hw It seems like we missed migrating the complete information from the old DT binding where we had described what the opp-supported-hw is supposed to describe. Hence, bring back the description from the previous binding to the current one along with a bit more context on what the values are supposed to be. Fixes: e576a9a8603f ("dt-bindings: cpufreq: Convert ti-cpufreq to json schema") Signed-off-by: Dhruva Gole Reviewed-by: Rob Herring (Arm) Signed-off-by: Viresh Kumar --- .../opp/operating-points-v2-ti-cpu.yaml | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml b/Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml index fd0c8d5c5f3e..624d1f3f1382 100644 --- a/Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml +++ b/Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml @@ -45,7 +45,25 @@ patternProperties: clock-latency-ns: true opp-hz: true opp-microvolt: true - opp-supported-hw: true + opp-supported-hw: + items: + items: + - description: + The revision of the SoC the OPP is supported by. + This can be easily obtained from the datasheet of the + part being ordered/used. For example, it will be 0x01 for SR1.0 + + - description: + The eFuse bits that indicate the particular OPP is available. + The device datasheet has a table talking about Device Speed Grades. + This table is to be sorted with only the unique elements of the + MAXIMUM OPERATING FREQUENCY starting from the first row which + tells the lowest OPP, to the highest. The corresponding bits + need to be set based on N elements of speed grade the device supports. + So, if there are 3 possible unique MAXIMUM OPERATING FREQUENCY + in the table, then BIT(0) | (1) | (2) will be set, which means + the value shall be 0x7. + opp-suspend: true turbo-mode: true