Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-15 02:05:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging/media/as102: Don't call release_firmware() on uninitialized variable

Browse Source 
If, in drivers/staging/media/as102/as102_fw.c::as102_fw_upload(), the call
	cmd_buf = kzalloc(MAX_FW_PKT_SIZE, GFP_KERNEL);
should fail and return NULL so that we jump to the 'error:' label,
then we'll end up calling 'release_firmware(firmware);' with
'firmware' still uninitialized - not good.

The easy fix is to just initialize 'firmware' to NULL when we declare
it, since release_firmware() deals gracefully with being passed NULL
pointers.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jesper Juhl 2012-03-24 23:39:18 +01:00 committed by Greg Kroah-Hartman
parent 218f4d437d
commit 401c90e56c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/media/as102/as102_fw.c
View File

@ -165,7 +165,7 @@ error:
int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap) int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap)
{ {
int errno = -EFAULT; int errno = -EFAULT;
const struct firmware *firmware; const struct firmware *firmware = NULL;
unsigned char *cmd_buf = NULL; unsigned char *cmd_buf = NULL;
char *fw1, *fw2; char *fw1, *fw2;
struct usb_device *dev = bus_adap->usb_dev; struct usb_device *dev = bus_adap->usb_dev;