From 642aadf148573d0b6c43707593ff144e0aaea9a6 Mon Sep 17 00:00:00 2001 From: Paolo Perego Date: Wed, 20 Nov 2024 14:57:27 +0100 Subject: [PATCH 1/5] staging:fbtft: Using str_true_false() helper instead of hardcoded strings Using str_true_false() helper instead of hardcoded strings. Signed-off-by: Paolo Perego Link: https://lore.kernel.org/r/20241120135727.376556-1-pperego@suse.de Signed-off-by: Greg Kroah-Hartman --- drivers/staging/fbtft/fb_ssd1351.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c index f6db2933ebba..6736b09b2f45 100644 --- a/drivers/staging/fbtft/fb_ssd1351.c +++ b/drivers/staging/fbtft/fb_ssd1351.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "fbtft.h" @@ -162,7 +163,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves) static int blank(struct fbtft_par *par, bool on) { fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n", - __func__, on ? "true" : "false"); + __func__, str_true_false(on)); if (on) write_reg(par, 0xAE); else From da6c337a8c075de5bf96139321fa4f67e004dd38 Mon Sep 17 00:00:00 2001 From: Marcelo Moreira Date: Sat, 23 Nov 2024 18:03:06 -0300 Subject: [PATCH 2/5] staging: rtl8723bs: change pointer initialization style Separated pdata and ptail initialization for clarity and to avoid potential issues. Signed-off-by: Marcelo Moreira Link: https://lore.kernel.org/r/20241123210329.70906-1-marcelomoreira1905@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 699cff7b0ac9..297c93d65315 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1467,7 +1467,8 @@ struct xmit_buf *rtw_alloc_xmitbuf_ext(struct xmit_priv *pxmitpriv) pxmitbuf->priv_data = NULL; pxmitbuf->len = 0; - pxmitbuf->pdata = pxmitbuf->ptail = pxmitbuf->phead; + pxmitbuf->pdata = pxmitbuf->phead; + pxmitbuf->ptail = pxmitbuf->phead; pxmitbuf->agg_num = 1; if (pxmitbuf->sctx) @@ -1526,7 +1527,8 @@ struct xmit_buf *rtw_alloc_xmitbuf(struct xmit_priv *pxmitpriv) pxmitbuf->priv_data = NULL; pxmitbuf->len = 0; - pxmitbuf->pdata = pxmitbuf->ptail = pxmitbuf->phead; + pxmitbuf->pdata = pxmitbuf->phead; + pxmitbuf->ptail = pxmitbuf->phead; pxmitbuf->agg_num = 0; pxmitbuf->pg_num = 0; From 724cc0cc17d9431f59b69f1e1d22c880c1e7ba60 Mon Sep 17 00:00:00 2001 From: Prarit Bhargava Date: Mon, 2 Dec 2024 11:03:57 -0500 Subject: [PATCH 3/5] staging: Fix tnt4882 license to be SPDX compliant "GPL-2" is not a valid SPDX license identifier[1]. Update to SPDX compliant string "GPL-2.0-only". [1] https://spdx.org/licenses Signed-off-by: Prarit Bhargava Cc: Dave Penkler Cc: Rohit Chavan Signed-off-by: Prarit Bhargava Link: https://lore.kernel.org/r/20241202160404.262993-1-prarit@redhat.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gpib/tnt4882/mite.c | 2 +- drivers/staging/gpib/tnt4882/mite.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/tnt4882/mite.c b/drivers/staging/gpib/tnt4882/mite.c index 0edf34d243e9..90341f8c394e 100644 --- a/drivers/staging/gpib/tnt4882/mite.c +++ b/drivers/staging/gpib/tnt4882/mite.c @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2 +// SPDX-License-Identifier: GPL-2.0-only /* * Hardware driver for NI Mite PCI interface chip, diff --git a/drivers/staging/gpib/tnt4882/mite.h b/drivers/staging/gpib/tnt4882/mite.h index 6454d069b8cc..fb84eaa83de3 100644 --- a/drivers/staging/gpib/tnt4882/mite.h +++ b/drivers/staging/gpib/tnt4882/mite.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2 */ +/* SPDX-License-Identifier: GPL-2.0-only */ /* * Hardware driver for NI Mite PCI interface chip From 2ff5bc6f5b4bb531907a9a2f57aec764c57fd4cb Mon Sep 17 00:00:00 2001 From: Dave Penkler Date: Wed, 4 Dec 2024 15:57:10 +0100 Subject: [PATCH 4/5] staging: gpib: Remove useless include linux/version.h not needed. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202410102259.zcoS9Eiu-lkp@intel.com/ Signed-off-by: Dave Penkler Link: https://lore.kernel.org/r/20241204145713.11889-2-dpenkler@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 796c3a5be545..9a3271e885d2 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -10,7 +10,6 @@ /* base module includes */ -#include #include #include #include From 0a4edbeef1e415f2eeaaae01b129f53f33c24d95 Mon Sep 17 00:00:00 2001 From: Dave Penkler Date: Wed, 4 Dec 2024 15:57:11 +0100 Subject: [PATCH 5/5] staging: gpib: Remove duplicate include linux/uaccess.h is included more than once. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202410110406.mQENnj09-lkp@intel.com/ Signed-off-by: Dave Penkler Link: https://lore.kernel.org/r/20241204145713.11889-3-dpenkler@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 9a3271e885d2..47db17418a74 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include "gpibP.h"