mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2025-01-10 07:50:04 +00:00
macvlan: silence RCU list debugging warning
macvlan_hash_lookup() uses list_for_each_entry_rcu() for traversing should either under RCU in fast path or the protection of rtnl_mutex. In the case of holding RTNL, we should add the corresponding lockdep expression to silence the following false-positive warning: ============================= WARNING: suspicious RCU usage 5.7.0-rc1-next-20200416-00003-ga3b8d28bc #1 Not tainted ----------------------------- drivers/net/macvlan.c:126 RCU-list traversed in non-reader section!! Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3f251d7411
commit
58e64a312c
@ -123,7 +123,8 @@ static struct macvlan_dev *macvlan_hash_lookup(const struct macvlan_port *port,
|
||||
struct macvlan_dev *vlan;
|
||||
u32 idx = macvlan_eth_hash(addr);
|
||||
|
||||
hlist_for_each_entry_rcu(vlan, &port->vlan_hash[idx], hlist) {
|
||||
hlist_for_each_entry_rcu(vlan, &port->vlan_hash[idx], hlist,
|
||||
lockdep_rtnl_is_held()) {
|
||||
if (ether_addr_equal_64bits(vlan->dev->dev_addr, addr))
|
||||
return vlan;
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user