Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-09 23:39:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

devtmpfs: get rid of bogus mkdir in create_path()

Browse Source 
We do _NOT_ want to mkdir the path itself - we are preparing to
mknod it, after all.  Normally it'll fail with -ENOENT and
just do nothing, but if somebody has created the parent in
the meanwhile, we'll get buggered...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2011-06-27 16:37:12 -04:00
parent 69753a0f14
commit 5da4e68944
1 changed files with 18 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/base/devtmpfs.c
View File

@ -164,19 +164,15 @@ static int dev_mkdir(const char *name, mode_t mode)
static int create_path(const char *nodepath) static int create_path(const char *nodepath)
{ {
int err;
err = dev_mkdir(nodepath, 0755);
if (err == -ENOENT) {
char *path; char *path;
char *s; char *s;
int err;
/* parent directories do not exist, create them */ /* parent directories do not exist, create them */
path = kstrdup(nodepath, GFP_KERNEL); path = kstrdup(nodepath, GFP_KERNEL);
if (!path) { if (!path)
err = -ENOMEM; return -ENOMEM;
goto out;
}
s = path; s = path;
for (;;) { for (;;) {
s = strchr(s, '/'); s = strchr(s, '/');
@ -190,8 +186,6 @@ static int create_path(const char *nodepath)
s++; s++;
} }
kfree(path); kfree(path);
}
out:
return err; return err;
} }