Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-09 15:29:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

devtmpfs: get rid of bogus mkdir in create_path()

Browse Source 
We do _NOT_ want to mkdir the path itself - we are preparing to
mknod it, after all.  Normally it'll fail with -ENOENT and
just do nothing, but if somebody has created the parent in
the meanwhile, we'll get buggered...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2011-06-27 16:37:12 -04:00
parent 69753a0f14
commit 5da4e68944
1 changed files with 18 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
drivers/base/devtmpfs.c
View File

@ -164,34 +164,28 @@ static int dev_mkdir(const char *name, mode_t mode)
static int create_path(const char *nodepath) static int create_path(const char *nodepath)
{ {
char *path;
char *s;
int err; int err;
err = dev_mkdir(nodepath, 0755); /* parent directories do not exist, create them */
if (err == -ENOENT) { path = kstrdup(nodepath, GFP_KERNEL);
char *path; if (!path)
char *s; return -ENOMEM;
/* parent directories do not exist, create them */ s = path;
path = kstrdup(nodepath, GFP_KERNEL); for (;;) {
if (!path) { s = strchr(s, '/');
err = -ENOMEM; if (!s)
goto out; break;
} s[0] = '\0';
s = path; err = dev_mkdir(path, 0755);
for (;;) { if (err && err != -EEXIST)
s = strchr(s, '/'); break;
if (!s) s[0] = '/';
break; s++;
s[0] = '\0';
err = dev_mkdir(path, 0755);
if (err && err != -EEXIST)
break;
s[0] = '/';
s++;
}
kfree(path);
} }
out: kfree(path);
return err; return err;
} }