Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2024-12-29 17:22:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rtc: bbnsm: add remove hook

Browse Source 
Without remove hook to clear wake irq, there will be kernel dump when
doing module test.
"bbnsm_rtc 44440000.bbnsm:rtc: wake irq already initialized"

Add remove hook to clear wake irq and set wakeup to false.

Fixes: eb7b85853c ("rtc: bbnsm: Add the bbnsm rtc support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20241111071130.1099978-1-peng.fan@oss.nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Peng Fan 2024-11-11 15:11:30 +08:00 committed by Alexandre Belloni
parent 5a36826a59
commit 60f0108bcc
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/rtc/rtc-nxp-bbnsm.c
View File

@ -197,13 +197,28 @@ static int bbnsm_rtc_probe(struct platform_device *pdev)
if (ret) { if (ret) {
dev_err(&pdev->dev, "failed to request irq %d: %d\n", dev_err(&pdev->dev, "failed to request irq %d: %d\n",
bbnsm->irq, ret); bbnsm->irq, ret);
return ret; goto err;
} }
bbnsm->rtc->ops = &bbnsm_rtc_ops; bbnsm->rtc->ops = &bbnsm_rtc_ops;
bbnsm->rtc->range_max = U32_MAX; bbnsm->rtc->range_max = U32_MAX;
return devm_rtc_register_device(bbnsm->rtc); ret = devm_rtc_register_device(bbnsm->rtc);
if (ret)
goto err;
return 0;
err:
dev_pm_clear_wake_irq(&pdev->dev);
device_init_wakeup(&pdev->dev, false);
return ret;
}
static void bbnsm_rtc_remove(struct platform_device *pdev)
{
dev_pm_clear_wake_irq(&pdev->dev);
device_init_wakeup(&pdev->dev, false);
} }
static const struct of_device_id bbnsm_dt_ids[] = { static const struct of_device_id bbnsm_dt_ids[] = {
@ -218,6 +233,7 @@ static struct platform_driver bbnsm_rtc_driver = {
.of_match_table = bbnsm_dt_ids, .of_match_table = bbnsm_dt_ids,
}, },
.probe = bbnsm_rtc_probe, .probe = bbnsm_rtc_probe,
.remove = bbnsm_rtc_remove,
}; };
module_platform_driver(bbnsm_rtc_driver); module_platform_driver(bbnsm_rtc_driver);