Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-13 01:08:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a sign bug causing invalid memory access in the ino_paths ioctl.

Browse Source 
To see the problem, create many hardlinks to the same file (120 should do it),
then look up paths by inode with:

  ls -i
  btrfs inspect inode-resolve -v $ino /mnt/btrfs

I noticed the memory layout of the fspath->val data had some irregularities
(some unnecessary gaps that stop appearing about halfway),
so I'm not sure there aren't any bugs left in it.
This commit is contained in:
Gabriel de Perthuis 2012-10-10 08:50:47 -06:00 committed by Chris Mason
parent f46dbe3dee
commit 661bec6ba8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/btrfs/backref.c
View File

@ -1186,7 +1186,7 @@ static char *ref_to_path(struct btrfs_root *fs_root,
int slot;
u64 next_inum;
int ret;
s64 bytes_left = size - 1;
s64 bytes_left = ((s64)size) - 1;
struct extent_buffer *eb = eb_in;
struct btrfs_key found_key;
int leave_spinning = path->leave_spinning;