Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-18 06:15:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phy: qcom-qmp-pcie: add config sanity checks

Browse Source 
The driver expects every configuration to set the pwrdn_ctrl and
phy_status masks. Add some probe WARN_ON_ONCE() to probe to catch any
new driver support that fails to provide them.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20221012085002.24099-17-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Johan Hovold 2022-10-12 10:49:59 +02:00 committed by Vinod Koul
parent 5806b87dea
commit 73ad6a9dd5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
View File

@ -2347,6 +2347,9 @@ static int qmp_pcie_probe(struct platform_device *pdev)
if (!cfg)
return -EINVAL;
WARN_ON_ONCE(!cfg->pwrdn_ctrl);
WARN_ON_ONCE(!cfg->phy_status);
serdes = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(serdes))
return PTR_ERR(serdes);