From 7598531c3aed26ffd98e054d8d9934e44c0e2c25 Mon Sep 17 00:00:00 2001 From: Breno Leitao Date: Fri, 8 Mar 2024 08:26:05 -0800 Subject: [PATCH] net: amt: Remove generic .ndo_get_stats64 Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao Reviewed-by: Taehee Yoo Link: https://lore.kernel.org/r/20240308162606.1597287-2-leitao@debian.org Signed-off-by: Jakub Kicinski --- drivers/net/amt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/amt.c b/drivers/net/amt.c index cb31d1990660..6d15ab3bfbbc 100644 --- a/drivers/net/amt.c +++ b/drivers/net/amt.c @@ -3084,7 +3084,6 @@ static const struct net_device_ops amt_netdev_ops = { .ndo_open = amt_dev_open, .ndo_stop = amt_dev_stop, .ndo_start_xmit = amt_dev_xmit, - .ndo_get_stats64 = dev_get_tstats64, }; static void amt_link_setup(struct net_device *dev)