Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-18 14:25:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libbpf: Remove unnecessary usdt_rel_ip assignments

Browse Source 
Coverity detected that usdt_rel_ip is unconditionally overwritten
anyways, so there is no need to unnecessarily initialize it with unused
value. Clean this up.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Yonghong Song <yhs@fb.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/bpf/20220705224818.4026623-4-andrii@kernel.org
This commit is contained in:
Andrii Nakryiko 2022-07-05 15:48:18 -07:00 committed by Daniel Borkmann
parent c46a122001
commit 7c8121af1b
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/lib/bpf/usdt.c
View File

@ -652,11 +652,9 @@ static int collect_usdt_targets(struct usdt_manager *man, Elf *elf, const char *
* *
* [0] https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation * [0] https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation
*/ */
usdt_rel_ip = usdt_abs_ip = note.loc_addr; usdt_abs_ip = note.loc_addr;
if (base_addr) { if (base_addr)
usdt_abs_ip += base_addr - note.base_addr; usdt_abs_ip += base_addr - note.base_addr;
usdt_rel_ip += base_addr - note.base_addr;
}
/* When attaching uprobes (which is what USDTs basically are) /* When attaching uprobes (which is what USDTs basically are)
* kernel expects file offset to be specified, not a relative * kernel expects file offset to be specified, not a relative