Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-12 00:38:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

PCI/msi: fix the pci_alloc_irq_vectors_affinity stub

Browse Source 
We need to return an error for any call that asks for MSI / MSI-X
vectors only, so that non-trivial fallback logic can work properly.

Also valid dev->irq and use the "correct" errno value based on feedback
from Linus.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Fixes: aff17164 ("PCI: Provide sensible IRQ vector alloc/free routines")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Christoph Hellwig 2017-05-20 18:59:54 +02:00 committed by Linus Torvalds
parent be941bf2e6
commit 83b4605b0c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/pci.h
View File

@ -1342,9 +1342,9 @@ pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
unsigned int max_vecs, unsigned int flags, unsigned int max_vecs, unsigned int flags,
const struct irq_affinity *aff_desc) const struct irq_affinity *aff_desc)
{ {
if (min_vecs > 1) if ((flags & PCI_IRQ_LEGACY) && min_vecs == 1 && dev->irq)
return -EINVAL; return 1;
return 1; return -ENOSPC;
} }
static inline void pci_free_irq_vectors(struct pci_dev *dev) static inline void pci_free_irq_vectors(struct pci_dev *dev)