Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-13 01:08:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vfio-pci: Fix possible integer overflow

Browse Source 
The VFIO_DEVICE_SET_IRQS ioctl takes a start and count parameter, both
of which are unsigned.  We attempt to bounds check these, but fail to
account for the case where start is a very large number, allowing
start + count to wrap back into the valid range.  Bounds check both
start and start + count.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Alex Williamson 2013-03-26 11:33:16 -06:00
parent 25e9789ddd
commit 904c680c7b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/vfio/pci/vfio_pci.c
View File

@ -346,6 +346,7 @@ static long vfio_pci_ioctl(void *device_data,
if (!(hdr.flags & VFIO_IRQ_SET_DATA_NONE)) { if (!(hdr.flags & VFIO_IRQ_SET_DATA_NONE)) {
size_t size; size_t size;
int max = vfio_pci_get_irq_count(vdev, hdr.index);
if (hdr.flags & VFIO_IRQ_SET_DATA_BOOL) if (hdr.flags & VFIO_IRQ_SET_DATA_BOOL)
size = sizeof(uint8_t); size = sizeof(uint8_t);
@ -355,7 +356,7 @@ static long vfio_pci_ioctl(void *device_data,
return -EINVAL; return -EINVAL;
if (hdr.argsz - minsz < hdr.count * size || if (hdr.argsz - minsz < hdr.count * size ||
hdr.count > vfio_pci_get_irq_count(vdev, hdr.index)) hdr.start >= max || hdr.start + hdr.count > max)
return -EINVAL; return -EINVAL;
data = memdup_user((void __user *)(arg + minsz), data = memdup_user((void __user *)(arg + minsz),