Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-15 11:17:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: pi433: use div_u64 for 64-bit division

Browse Source 
I ran into this link error on an ARM OABI build:

drivers/staging/pi433/rf69.o: In function `rf69_set_frequency':
rf69.c:(.text+0xc9c): undefined reference to `__udivdi3'

No idea why I didn't see it with the default EABI configurations,
but the right solution here seems to be to use div_u64()
to get the external division implementation.

Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Arnd Bergmann 2017-07-28 15:23:12 +02:00 committed by Greg Kroah-Hartman
parent 056eeda2f9
commit 99859541a9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/pi433/rf69.c
View File

@ -238,7 +238,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 frequency)
do_div(f_step, 524288); // 524288 = 2^19 do_div(f_step, 524288); // 524288 = 2^19
// check input value // check input value
f_max = f_step * 8388608 / factor; f_max = div_u64(f_step * 8388608, factor);
if (frequency > f_max) if (frequency > f_max)
{ {
dev_dbg(&spi->dev, "setFrequency: illegal input param"); dev_dbg(&spi->dev, "setFrequency: illegal input param");