Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-15 02:05:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

module: Don't fail module loading when setting ro_after_init section RO failed

Browse Source 
Once module init has succeded it is too late to cancel loading.
If setting ro_after_init data section to read-only fails, all we
can do is to inform the user through a warning.

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/all/20230915082126.4187913-1-ruanjinjie@huawei.com/
Fixes: d1909c022173 ("module: Don't ignore errors from set_memory_XX()")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/d6c81f38da76092de8aacc8c93c4c65cb0fe48b8.1733427536.git.christophe.leroy@csgroup.eu
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
This commit is contained in:
Christophe Leroy 2024-12-05 20:46:16 +01:00 committed by Petr Pavlu
parent 570f7776db
commit 9b894ee433
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/module/main.c
View File

@ -2955,7 +2955,10 @@ static noinline int do_init_module(struct module *mod)
#endif #endif
ret = module_enable_rodata_ro_after_init(mod); ret = module_enable_rodata_ro_after_init(mod);
if (ret) if (ret)
goto fail_mutex_unlock; pr_warn("%s: module_enable_rodata_ro_after_init() returned %d, "
"ro_after_init data might still be writable\n",
mod->name, ret);
mod_tree_remove_init(mod); mod_tree_remove_init(mod);
module_arch_freeing_init(mod); module_arch_freeing_init(mod);
for_class_mod_mem_type(type, init) { for_class_mod_mem_type(type, init) {
@ -2994,8 +2997,6 @@ static noinline int do_init_module(struct module *mod)
return 0; return 0;
fail_mutex_unlock:
mutex_unlock(&module_mutex);
fail_free_freeinit: fail_free_freeinit:
kfree(freeinit); kfree(freeinit);
fail: fail: