Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-04 04:02:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dyndbg: Remove support for ddebug_query param

Browse Source 
This param has been deprecated for a very long time now, let's rip it
out.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Jason Baron <jbaron@akamai.com>
Link: https://lore.kernel.org/r/1634139622-20667-3-git-send-email-jbaron@akamai.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andrew Halaney 2021-10-13 11:40:21 -04:00 committed by Greg Kroah-Hartman
parent 5ca1739748
commit 9c40e1aa84
3 changed files with 2 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Documentation/admin-guide/dynamic-debug-howto.rst
View File

@ -249,8 +249,7 @@ Debug messages during Boot Process
To activate debug messages for core code and built-in modules during To activate debug messages for core code and built-in modules during
the boot process, even before userspace and debugfs exists, use the boot process, even before userspace and debugfs exists, use
``dyndbg="QUERY"``, ``module.dyndbg="QUERY"``, or ``ddebug_query="QUERY"`` ``dyndbg="QUERY"`` or ``module.dyndbg="QUERY"``. QUERY follows
(``ddebug_query`` is obsoleted by ``dyndbg``, and deprecated). QUERY follows
the syntax described above, but must not exceed 1023 characters. Your the syntax described above, but must not exceed 1023 characters. Your
bootloader may impose lower limits. bootloader may impose lower limits.
@ -270,8 +269,7 @@ this boot parameter for debugging purposes.
If ``foo`` module is not built-in, ``foo.dyndbg`` will still be processed at If ``foo`` module is not built-in, ``foo.dyndbg`` will still be processed at
boot time, without effect, but will be reprocessed when module is boot time, without effect, but will be reprocessed when module is
loaded later. ``ddebug_query=`` and bare ``dyndbg=`` are only processed at loaded later. Bare ``dyndbg=`` is only processed at boot.
boot.
Debug Messages at Module Initialization Time Debug Messages at Module Initialization Time

5
Documentation/admin-guide/kernel-parameters.txt
View File

@ -841,11 +841,6 @@
Format: <port#>,<type> Format: <port#>,<type>
See also Documentation/input/devices/joystick-parport.rst See also Documentation/input/devices/joystick-parport.rst
ddebug_query= [KNL,DYNAMIC_DEBUG] Enable debug messages at early boot
time. See
Documentation/admin-guide/dynamic-debug-howto.rst for
details. Deprecated, see dyndbg.
debug [KNL] Enable kernel debugging (events log level). debug [KNL] Enable kernel debugging (events log level).
debug_boot_weak_hash debug_boot_weak_hash

25
lib/dynamic_debug.c
View File

@ -746,21 +746,6 @@ EXPORT_SYMBOL(__dynamic_ibdev_dbg);
#endif #endif
#define DDEBUG_STRING_SIZE 1024
static __initdata char ddebug_setup_string[DDEBUG_STRING_SIZE];
static __init int ddebug_setup_query(char *str)
{
if (strlen(str) >= DDEBUG_STRING_SIZE) {
pr_warn("ddebug boot param string too large\n");
return 0;
}
strlcpy(ddebug_setup_string, str, DDEBUG_STRING_SIZE);
return 1;
}
__setup("ddebug_query=", ddebug_setup_query);
/* /*
* Install a noop handler to make dyndbg look like a normal kernel cli param. * Install a noop handler to make dyndbg look like a normal kernel cli param.
* This avoids warnings about dyndbg being an unknown cli param when supplied * This avoids warnings about dyndbg being an unknown cli param when supplied
@ -1133,16 +1118,6 @@ static int __init dynamic_debug_init(void)
entries, modct, (int)((modct * sizeof(struct ddebug_table)) >> 10), entries, modct, (int)((modct * sizeof(struct ddebug_table)) >> 10),
(int)((entries * sizeof(struct _ddebug)) >> 10)); (int)((entries * sizeof(struct _ddebug)) >> 10));
/* apply ddebug_query boot param, dont unload tables on err */
if (ddebug_setup_string[0] != '\0') {
pr_warn("ddebug_query param name is deprecated, change it to dyndbg\n");
ret = ddebug_exec_queries(ddebug_setup_string, NULL);
if (ret < 0)
pr_warn("Invalid ddebug boot param %s\n",
ddebug_setup_string);
else
pr_info("%d changes by ddebug_query\n", ret);
}
/* now that ddebug tables are loaded, process all boot args /* now that ddebug tables are loaded, process all boot args
* again to find and activate queries given in dyndbg params. * again to find and activate queries given in dyndbg params.
* While this has already been done for known boot params, it * While this has already been done for known boot params, it