Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-09 15:29:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fbdev: omapfb/dsi-cm: Don't put .remove() in .exit.text and drop suppress_bind_attrs

Browse Source 
On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

	WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm: section mismatch in reference: dsicm_driver+0x4 (section: .data) -> dsicm_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Uwe Kleine-König 2023-11-07 10:17:46 +01:00 committed by Helge Deller
parent bfaee69738
commit b02e6f70f8
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
View File

@ -1241,7 +1241,7 @@ err_reg:
return r; return r;
} }
static int __exit dsicm_remove(struct platform_device *pdev) static int dsicm_remove(struct platform_device *pdev)
{ {
struct panel_drv_data *ddata = platform_get_drvdata(pdev); struct panel_drv_data *ddata = platform_get_drvdata(pdev);
struct omap_dss_device *dssdev = &ddata->dssdev; struct omap_dss_device *dssdev = &ddata->dssdev;
@ -1282,11 +1282,10 @@ MODULE_DEVICE_TABLE(of, dsicm_of_match);
static struct platform_driver dsicm_driver = { static struct platform_driver dsicm_driver = {
.probe = dsicm_probe, .probe = dsicm_probe,
.remove = __exit_p(dsicm_remove), .remove = dsicm_remove,
.driver = { .driver = {
.name = "panel-dsi-cm", .name = "panel-dsi-cm",
.of_match_table = dsicm_of_match, .of_match_table = dsicm_of_match,
.suppress_bind_attrs = true,
}, },
}; };