Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-17 05:45:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

net: phy: simplify a check in phy_check_link_status

Browse Source 
Handling case err == 0 in the other branch allows to simplify the
code. In addition I assume in "err & phydev->eee_cfg.tx_lpi_enabled"
it should have been a logical and operator. It works as expected also
with the bitwise and, but using a bitwise and with a bool value looks
ugly to me.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/de37bf30-61dd-49f9-b645-2d8ea11ddb5d@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Heiner Kallweit 2024-03-07 22:16:12 +01:00 committed by Jakub Kicinski
parent 22ca20fd12
commit c786459fc8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/phy/phy.c
View File

@ -985,10 +985,10 @@ static int phy_check_link_status(struct phy_device *phydev)
phydev->state = PHY_RUNNING;
err = genphy_c45_eee_is_active(phydev,
NULL, NULL, NULL);
if (err < 0)
if (err <= 0)
phydev->enable_tx_lpi = false;
else
phydev->enable_tx_lpi = (err & phydev->eee_cfg.tx_lpi_enabled);
phydev->enable_tx_lpi = phydev->eee_cfg.tx_lpi_enabled;
phy_link_up(phydev);
} else if (!phydev->link && phydev->state != PHY_NOLINK) {