mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
synced 2025-01-01 10:42:11 +00:00
Documentation/atomic_t: Document cmpxchg() vs try_cmpxchg()
There seems to be a significant amount of confusion around the new try_cmpxchg(), despite this being more like the C11 atomic_compare_exchange_*() family. Add a few words of clarification on how cmpxchg() and try_cmpxchg() relate to one another. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Will Deacon <will@kernel.org> Link: https://lkml.kernel.org/r/YOMgPeMOmmiK3tXO@hirez.programming.kicks-ass.net
This commit is contained in:
parent
e6b4457b05
commit
d1bbfd0c7c
@ -271,3 +271,44 @@ WRITE_ONCE. Thus:
|
|||||||
SC *y, t;
|
SC *y, t;
|
||||||
|
|
||||||
is allowed.
|
is allowed.
|
||||||
|
|
||||||
|
|
||||||
|
CMPXCHG vs TRY_CMPXCHG
|
||||||
|
----------------------
|
||||||
|
|
||||||
|
int atomic_cmpxchg(atomic_t *ptr, int old, int new);
|
||||||
|
bool atomic_try_cmpxchg(atomic_t *ptr, int *oldp, int new);
|
||||||
|
|
||||||
|
Both provide the same functionality, but try_cmpxchg() can lead to more
|
||||||
|
compact code. The functions relate like:
|
||||||
|
|
||||||
|
bool atomic_try_cmpxchg(atomic_t *ptr, int *oldp, int new)
|
||||||
|
{
|
||||||
|
int ret, old = *oldp;
|
||||||
|
ret = atomic_cmpxchg(ptr, old, new);
|
||||||
|
if (ret != old)
|
||||||
|
*oldp = ret;
|
||||||
|
return ret == old;
|
||||||
|
}
|
||||||
|
|
||||||
|
and:
|
||||||
|
|
||||||
|
int atomic_cmpxchg(atomic_t *ptr, int old, int new)
|
||||||
|
{
|
||||||
|
(void)atomic_try_cmpxchg(ptr, &old, new);
|
||||||
|
return old;
|
||||||
|
}
|
||||||
|
|
||||||
|
Usage:
|
||||||
|
|
||||||
|
old = atomic_read(&v); old = atomic_read(&v);
|
||||||
|
for (;;) { do {
|
||||||
|
new = func(old); new = func(old);
|
||||||
|
tmp = atomic_cmpxchg(&v, old, new); } while (!atomic_try_cmpxchg(&v, &old, new));
|
||||||
|
if (tmp == old)
|
||||||
|
break;
|
||||||
|
old = tmp;
|
||||||
|
}
|
||||||
|
|
||||||
|
NB. try_cmpxchg() also generates better code on some platforms (notably x86)
|
||||||
|
where the function more closely matches the hardware instruction.
|
||||||
|
Loading…
Reference in New Issue
Block a user