Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-09 15:29:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

kconfig: fix missing fclose() on error paths

Browse Source 
The file is not closed when ferror() fails.

Fixes: 00d674cb3536 ("kconfig: refactor conf_write_dep()")
Fixes: 57ddd07c4560 ("kconfig: refactor conf_write_autoconf()")
Reported-by: Ryan Cai <ycaibb@gmail.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada 2022-02-08 15:26:18 +09:00
parent 1cf5f151d2
commit d23a0c3718
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/kconfig/confdata.c
View File

@ -979,10 +979,10 @@ static int conf_write_autoconf_cmd(const char *autoconf_name)
fprintf(out, "\n$(deps_config): ;\n"); fprintf(out, "\n$(deps_config): ;\n");
if (ferror(out)) /* error check for all fprintf() calls */ ret = ferror(out); /* error check for all fprintf() calls */
return -1;
fclose(out); fclose(out);
if (ret)
return -1;
if (rename(tmp, name)) { if (rename(tmp, name)) {
perror("rename"); perror("rename");
@ -1093,10 +1093,10 @@ static int __conf_write_autoconf(const char *filename,
print_symbol(file, sym); print_symbol(file, sym);
/* check possible errors in conf_write_heading() and print_symbol() */ /* check possible errors in conf_write_heading() and print_symbol() */
if (ferror(file)) ret = ferror(file);
return -1;
fclose(file); fclose(file);
if (ret)
return -1;
if (rename(tmp, filename)) { if (rename(tmp, filename)) {
perror("rename"); perror("rename");