Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-16 13:34:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

um: fix stub exe build with CONFIG_GCOV

Browse Source 
CONFIG_GCOV is special and only in UML since it builds the
kernel with a "userspace" option. This is fine, but the stub
is even more special and not really a full userspace process,
so it then fails to link as reported.

Remove the GCOV options from the stub build.

For good measure, also remove the GPROF options, even though
they don't seem to cause build failures now.

To be able to do this, export the specific options (GCOV_OPT
and GPROF_OPT) but rename them so there's less chance of any
conflicts.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410242238.SXhs2kQ4-lkp@intel.com/
Fixes: 32e8eaf263d9 ("um: use execveat to create userspace MMs")
Link: https://patch.msgid.link/20241025102700.9fbb9c34473f.I7f1537fe075638f8da64beb52ef6c9e5adc51bc3@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Johannes Berg 2024-10-25 10:27:01 +02:00
parent 42b8b00c8a
commit d3b08e5f3f
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
arch/um/Makefile-skas
View File

@ -3,15 +3,15 @@
# Licensed under the GPL # Licensed under the GPL
# #
GPROF_OPT += -pg export UM_GPROF_OPT += -pg
ifdef CONFIG_CC_IS_CLANG ifdef CONFIG_CC_IS_CLANG
GCOV_OPT += -fprofile-instr-generate -fcoverage-mapping export UM_GCOV_OPT += -fprofile-instr-generate -fcoverage-mapping
else else
GCOV_OPT += -fprofile-arcs -ftest-coverage export UM_GCOV_OPT += -fprofile-arcs -ftest-coverage
endif endif
CFLAGS-$(CONFIG_GCOV) += $(GCOV_OPT) CFLAGS-$(CONFIG_GCOV) += $(UM_GCOV_OPT)
CFLAGS-$(CONFIG_GPROF) += $(GPROF_OPT) CFLAGS-$(CONFIG_GPROF) += $(UM_GPROF_OPT)
LINK-$(CONFIG_GCOV) += $(GCOV_OPT) LINK-$(CONFIG_GCOV) += $(UM_GCOV_OPT)
LINK-$(CONFIG_GPROF) += $(GPROF_OPT) LINK-$(CONFIG_GPROF) += $(UM_GPROF_OPT)

2
arch/um/kernel/skas/Makefile
View File

@ -24,7 +24,7 @@ $(obj)/stub_exe: $(obj)/stub_exe.dbg FORCE
quiet_cmd_stub_exe = STUB_EXE $@ quiet_cmd_stub_exe = STUB_EXE $@
cmd_stub_exe = $(CC) -nostdlib -o $@ \ cmd_stub_exe = $(CC) -nostdlib -o $@ \
$(KBUILD_CFLAGS) $(STUB_EXE_LDFLAGS) \ $(filter-out $(UM_GPROF_OPT) $(UM_GCOV_OPT),$(KBUILD_CFLAGS)) $(STUB_EXE_LDFLAGS) \
$(filter %.o,$^) $(filter %.o,$^)
STUB_EXE_LDFLAGS = -Wl,-n -static STUB_EXE_LDFLAGS = -Wl,-n -static