Kernel/linux-next
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git synced 2025-01-16 05:26:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

misc: pch_phub: Constify 'struct bin_attribute'

Browse Source 
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-6-ba5e79fe8771@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Thomas Weißschuh 2024-12-21 15:48:12 +01:00 committed by Greg Kroah-Hartman
parent fc58d178b0
commit e588522da8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/misc/pch_phub.c
View File

@ -483,7 +483,7 @@ static int pch_phub_write_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data)
} }
static ssize_t pch_phub_bin_read(struct file *filp, struct kobject *kobj, static ssize_t pch_phub_bin_read(struct file *filp, struct kobject *kobj,
struct bin_attribute *attr, char *buf, const struct bin_attribute *attr, char *buf,
loff_t off, size_t count) loff_t off, size_t count)
{ {
unsigned int rom_signature; unsigned int rom_signature;
@ -553,7 +553,7 @@ return_err_nomutex:
} }
static ssize_t pch_phub_bin_write(struct file *filp, struct kobject *kobj, static ssize_t pch_phub_bin_write(struct file *filp, struct kobject *kobj,
struct bin_attribute *attr, const struct bin_attribute *attr,
char *buf, loff_t off, size_t count) char *buf, loff_t off, size_t count)
{ {
int err; int err;
@ -655,8 +655,8 @@ static const struct bin_attribute pch_bin_attr = {
.mode = S_IRUGO | S_IWUSR, .mode = S_IRUGO | S_IWUSR,
}, },
.size = PCH_PHUB_OROM_SIZE + 1, .size = PCH_PHUB_OROM_SIZE + 1,
.read = pch_phub_bin_read, .read_new = pch_phub_bin_read,
.write = pch_phub_bin_write, .write_new = pch_phub_bin_write,
}; };
static int pch_phub_probe(struct pci_dev *pdev, static int pch_phub_probe(struct pci_dev *pdev,